Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dbconn.Exec in checkpoint #328

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Use dbconn.Exec in checkpoint #328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5a3430
Use dbconn.Exec in checkpoint
morgo Jul 8, 2024
8407c58
fix quoted name
morgo Jul 8, 2024
fbbd7e8
Merge branch 'main' into mtocker-fix-checkpoint
morgo Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pkg/migration/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,10 +896,16 @@ func (r *Runner) dumpCheckpoint(ctx context.Context) error {
// We believe this is OK but may change it in the future. Please do not
// add any other fields to this log line.
r.logger.Infof("checkpoint: low-watermark=%s log-file=%s log-pos=%d rows-copied=%d rows-copied-logical=%d", lowWatermark, binlog.Name, binlog.Pos, copyRows, logicalCopyRows)
query := fmt.Sprintf("INSERT INTO %s (low_watermark, binlog_name, binlog_pos, rows_copied, rows_copied_logical, alter_statement) VALUES (?, ?, ?, ?, ?, ?)",
r.checkpointTable.QuotedName)
_, err = r.db.ExecContext(ctx, query, lowWatermark, binlog.Name, binlog.Pos, copyRows, logicalCopyRows, r.migration.Alter)
return err
return dbconn.Exec(ctx, r.db, "INSERT INTO %n.%n (low_watermark, binlog_name, binlog_pos, rows_copied, rows_copied_logical, alter_statement) VALUES (%?, %?, %?, %?, %?, %?)",
r.checkpointTable.SchemaName,
r.checkpointTable.TableName,
lowWatermark,
binlog.Name,
binlog.Pos,
copyRows,
logicalCopyRows,
r.migration.Alter,
)
}

func (r *Runner) dumpCheckpointContinuously(ctx context.Context) {
Expand Down
Loading