Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Sandwich standardization and tweaks #4456

Merged
merged 6 commits into from
Apr 7, 2024

Conversation

Lamandus
Copy link
Contributor

@Lamandus Lamandus commented Apr 7, 2024

Purpose of change

Sandwiches were all over the place. Strange values, no standard charges and very sloppy "coding". Spawns were also very strange.

Describe the solution

  1. Use "copy-from" for all sandwiches, deluxe being the standard
  2. remove cucumber and BLT sandwiches
  3. spawn deluxe and deluxe no cheese in different places
  4. spawn a lot more deluxe sandwiches
  5. only one charge is produced per craft
  6. all have the same volume and weight because a 250 ml ingredient pile got 1500 ml out of nowhere

Describe alternatives you've considered

Testing

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Apr 7, 2024
Copy link
Contributor

autofix-ci bot commented Apr 7, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Lamandus Lamandus requested a review from chaosvolt April 7, 2024 22:01
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic idea seems good but obsoleting BLT is probably gonna look weird.

@Lamandus
Copy link
Contributor Author

Lamandus commented Apr 7, 2024

Basic idea seems good but obsoleting BLT is probably gonna look weird.

I take the blame from BLT lovers. The Deluxe version also can use bacon has more enjoy-ability, and is a lot more versatile

@chaosvolt
Copy link
Member

If the tests pass I guess... ¯_(ツ)_/¯

@Lamandus
Copy link
Contributor Author

Lamandus commented Apr 7, 2024

If the tests pass I guess... ¯_(ツ)_/¯

you lost an arm

@Lamandus Lamandus merged commit 8690f8a into cataclysmbnteam:main Apr 7, 2024
10 checks passed
@Lamandus Lamandus deleted the doublesandwich branch April 7, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants