Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USGS USWTDB data #539

Merged
merged 15 commits into from
Feb 6, 2025
Merged

Add USGS USWTDB data #539

merged 15 commits into from
Feb 6, 2025

Conversation

marianneke
Copy link
Member

@marianneke marianneke commented Jan 23, 2025

Overview

Closes #513

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

Tasks

Preview Give feedback

@marianneke marianneke marked this pull request as draft January 23, 2025 15:42
@e-belfer e-belfer linked an issue Jan 24, 2025 that may be closed by this pull request
3 tasks
@zaneselvans zaneselvans force-pushed the marianneke-usgsuswtdb branch from fa35a8c to a4c5438 Compare January 31, 2025 20:11
@zaneselvans zaneselvans changed the base branch from main to marianneke-generalize-hyperlink-extractor January 31, 2025 20:13
@zaneselvans zaneselvans marked this pull request as ready for review January 31, 2025 22:09
@zaneselvans zaneselvans requested a review from e-belfer January 31, 2025 22:09
Base automatically changed from marianneke-generalize-hyperlink-extractor to main February 3, 2025 21:18
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to also add this to the checklist in .github/monthly-archive-update.md (see #575 for examples of me doing this retroactively for the other datasets). I am doing this in #575, never mind!

Otherwise, my comments are non-blocking and minor, so I'll go ahead and approve this. Was able to successfully create a "no changes detected" update on the sandbox server.

@e-belfer e-belfer added the usgswtdb USGS U.S. Wind Turbine Database label Feb 4, 2025
@zaneselvans zaneselvans merged commit fc7950f into main Feb 6, 2025
3 checks passed
@zaneselvans zaneselvans deleted the marianneke-usgsuswtdb branch February 6, 2025 03:13
@zaneselvans
Copy link
Member

@e-belfer I went ahead and merged this since it was approved and it looked like @marianneke had also addressed your last comment.

e-belfer added a commit that referenced this pull request Feb 17, 2025
* add archiver for USGS USWTDB
* rename
* add to select year supported datasets
* clarify extracting date parts
* [pre-commit.ci] auto fixes from pre-commit.com hooks
For more information, see https://pre-commit.ci
* Log remote URL and local download paths.
* Construct valid ZIP file download URLs
* Don't fail on date discontinuities
* Add Zenodo DOIs for USGS US Wind Turbine DB
* Add USGS US Wind Turbine DB to run-archiver workflow.
* Use concept DOIs not v1.0 for USGS US Wind Turbine DB.
* update docstring and improve logging

---------

Co-authored-by: Marianne Hoogeveen <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Zane Selvans <[email protected]>
Co-authored-by: E. Belfer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community new-data usgswtdb USGS U.S. Wind Turbine Database
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Write an archiver for USGS U.S. Wind Turbine Database
3 participants