Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google): init #325

Merged
merged 42 commits into from
Dec 1, 2023
Merged

feat(google): init #325

merged 42 commits into from
Dec 1, 2023

Conversation

GitMuslim
Copy link
Member

@GitMuslim GitMuslim commented Nov 17, 2023

🎉 Theme for Google 🎉

Google is a search engine.

💬 Additional Comments 💬

if u find any uncolored stuff tell me

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • assets/mocha.webp, assets/macchiato.webp, assets/frappe.webp and
      assets/latte.webp - individual screenshots of the themed website, in all 4
      Catppuccin flavors.
    • catwalk.webp - image of all individual screenshots stitched together,
      generated via catwalk.

@GitMuslim GitMuslim mentioned this pull request Nov 17, 2023
1 task
@GitMuslim GitMuslim changed the title Google feat(google): init Nov 17, 2023
@isabelroses
Copy link
Member

Hi @GitMuslim,

I'm just going to put this on pause until #323 is merged as this may result in you having to make some changes to your code.

Thanks for your patience.

README.md Outdated Show resolved Hide resolved
styles/google/README.md Outdated Show resolved Hide resolved
styles/google/LICENSE Outdated Show resolved Hide resolved
@uncenter
Copy link
Member

uncenter commented Nov 18, 2023

Awesome! Looking good. Just a few interaction modals I noticed that weren't themed in testing:

Unthemed "I'm feeling lucky" button on hover Unthemed 'I'm feeling lucky' button on you hover over it
Unthemed Google image search box Gif of opening the Google image search box and it being unthemed
Unthemed profile popup Screenshot of the unthemed popup when you click on your Google profile picture
Unthemed Google apps launchpad popup Screenshot of the unthemed popup when you click the Google Apps Launchpad

@nekowinston
Copy link
Contributor

Unthemed profile popup

This also applies to the modal when you're signed out or don't have an account.

@isabelroses
Copy link
Member

Unthemed Google apps launchpad popup

It might be better if this is left unthemed unless it can be done properly in a way that across the google apps its properly themed.

@uncenter
Copy link
Member

uncenter commented Nov 18, 2023

Unthemed Google apps launchpad popup

It might be better if this is left unthemed unless it can be done properly in a way that across the google apps its properly themed.

I think everything on the page should be themed, and we shouldn't leave a part while we wait for all of the other Google apps to be themed.

@GitMuslim
Copy link
Member Author

Unthemed Google apps launchpad popup

It might be better if this is left unthemed unless it can be done properly in a way that across the google apps its properly themed.

this was themed in the old stylus file, I see no reason to not have it themed here.

@GitMuslim
Copy link
Member Author

@uncenter the "Unthemed "I'm feeling lucky" button on hover" thing doesn't happen on my side, it's just a normal button, there's no animation

@uncenter
Copy link
Member

uncenter commented Nov 18, 2023

I'm seeing it on multiple devices. Signed in, hovering over the button. @isabelroses @nekowinston are you guys seeing it?

@isabelroses
Copy link
Member

isabelroses commented Nov 18, 2023

I'm seeing it on multiple devices. Signed in, hovering over the button.

For me its also unthemed.
Just as a point of comparison the selector for me is .lJ9FBc input[type="submit"], .gbqfba.

@nekowinston
Copy link
Contributor

nekowinston commented Nov 18, 2023

@uncenter the "Unthemed "I'm feeling lucky" button on hover" thing doesn't happen on my side, it's just a normal button, there's no animation

I'm seeing it on multiple devices. Signed in, hovering over the button. @isabelroses @nekowinston are you guys seeing it?

I don't get the hover effect either - since I don't really use Google I'll let you guys handle the rest of the review.

@isabelroses
Copy link
Member

I also just noticed when viewing the page sometimes the gmail and other top text is broken the selector for me is a.gb_E, span.gb_E. See the image bellow.

image

@uncenter
Copy link
Member

I also just noticed when viewing the page sometimes the gmail and other top text is broken the selector for me is a.gb_E, span.gb_E. See the image bellow.

image

I think this is if you have Google set to light mode (click settings in the bottom right of google.com) btw.

@aemogie
Copy link
Contributor

aemogie commented Nov 22, 2023

I have no idea how to reproduce this but, the class for the background is .lwwARb. I don't remember if it needed !important or not, though. Refreshed and it went away.
image

@isabelroses
Copy link
Member

isabelroses commented Nov 22, 2023

Also just noticed (located under an image)
image

@GitMuslim
Copy link
Member Author

I have no idea how to reproduce this but, the class for the background is .lwwARb. I don't remember if it needed !important or not, though. Refreshed and it went away. image

I won't color something I cannot see unless it's very simple otherwise idk, if you want to you can contribute to this repo

@GitMuslim
Copy link
Member Author

GitMuslim commented Nov 24, 2023

Awesome! Looking good. Just a few interaction modals I noticed that weren't themed in testing:
Unthemed "I'm feeling lucky" button on hover
Unthemed Google image search box
Unthemed profile popup
Unthemed Google apps launchpad popup

fixed it all, not sure if the first one is fixed tho.

@GitMuslim
Copy link
Member Author

I also just noticed when viewing the page sometimes the gmail and other top text is broken the selector for me is a.gb_E, span.gb_E. See the image bellow.

image

fixed too

@isabelroses isabelroses merged commit 3d8710a into catppuccin:main Dec 1, 2023
4 checks passed
@GitMuslim
Copy link
Member Author

Thanks!

@GitMuslim GitMuslim deleted the feat/google branch December 1, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants