-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing MARK03 Experiment #114
Conversation
As of now, MARK03 is implemented with RANDOM, DEEP, STAR and HUNTRESS trees - the MCMC5 trees are still completely missing. There are some issues with the huntress trees. Apparently, HUNTRESS does not guarantee to include all mutations in the mutation matrix. This brings additional complexity. To nevertheless start an MCMC in those cases, one would have to remove this mutation from the mutation matrix - otherwise, that is not compatible with SCITE. This appears cumbersome and flawed in many ways. Hence, I propose to catch those cases and plot the final log_prob / metric to iteration plot without the Huntress tree in those cases. Also next
|
Came across:
|
Need to
|
This PR also removes snakefmt again / deactivates it for now as the code is intended where it should not be. Issues have been raised with developers: |
This PR implements/closes:
will also address