Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing MARK03 Experiment #114

Merged
merged 27 commits into from
Jul 20, 2023
Merged

Implementing MARK03 Experiment #114

merged 27 commits into from
Jul 20, 2023

Conversation

gordonkoehn
Copy link
Collaborator

@gordonkoehn gordonkoehn commented Jul 11, 2023

@gordonkoehn gordonkoehn self-assigned this Jul 11, 2023
@gordonkoehn gordonkoehn added 🦾 action: enhancement New feature or request ❗priority: high 🧩 in sprint Issues which have been added to a sprint ⏰ time estimate: L 🧪 action: experiment Used for experiments and Proof of Concepts, which not necessarily are to be merged labels Jul 11, 2023
scripts/make_huntress.py Show resolved Hide resolved
workflows/mark01.smk Show resolved Hide resolved
workflows/tree_inference.smk Show resolved Hide resolved
@gordonkoehn
Copy link
Collaborator Author

gordonkoehn commented Jul 13, 2023

As of now, MARK03 is implemented with RANDOM, DEEP, STAR and HUNTRESS trees - the MCMC5 trees are still completely missing.

There are some issues with the huntress trees. Apparently, HUNTRESS does not guarantee to include all mutations in the mutation matrix. This brings additional complexity. To nevertheless start an MCMC in those cases, one would have to remove this mutation from the mutation matrix - otherwise, that is not compatible with SCITE. This appears cumbersome and flawed in many ways.

Hence, I propose to catch those cases and plot the final log_prob / metric to iteration plot without the Huntress tree in those cases.
Therefore, it appears best to run the mark03 experiment always with snakemake --keep-going mark03 to allow the failure of some process branches, whilst also implementing the plotting of the final plots without huntress once per default.

Also next

  • document and comment well
  • remove unnecessary HUNTRESS ID from _file_id.
  • add the MCMC5 tree generator
  • fix position of legend

@gordonkoehn
Copy link
Collaborator Author

Came across:

@gordonkoehn
Copy link
Collaborator Author

gordonkoehn commented Jul 19, 2023

yg.tree_inference.evolve_tree_mcmc() implements the mcmc tree evolver.

Need to

  • integrate into the MARK03 workflow now.

@gordonkoehn gordonkoehn marked this pull request as ready for review July 20, 2023 08:19
@gordonkoehn
Copy link
Collaborator Author

gordonkoehn commented Jul 20, 2023

This PR also removes snakefmt again / deactivates it for now as the code is intended where it should not be. Issues have been raised with developers:

@gordonkoehn gordonkoehn merged commit 503d2fc into main Jul 20, 2023
@gordonkoehn gordonkoehn deleted the gordon/mark03 branch July 20, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦾 action: enhancement New feature or request 🧪 action: experiment Used for experiments and Proof of Concepts, which not necessarily are to be merged 🧩 in sprint Issues which have been added to a sprint ❗priority: high ⏰ time estimate: L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run MARK03 Test MARK03 Refactor tree_from_tree_node to be static of Tree
1 participant