Skip to content

Commit

Permalink
temporary workaround for snakemake 8's breaking changes
Browse files Browse the repository at this point in the history
  • Loading branch information
DrYak committed Dec 27, 2023
1 parent 8d05c77 commit 25fd3a9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ ARG vpipe_path=${install_path}/V-pipe
ARG envs_path=${install_path}/conda_envs
ARG test_data=/test-data
ARG virus_download_list
ARG snaketag=stable
# HACK Snakemake v8 has breaking changes
ARG snaketag=v7.32.4

###
### Stage 0: download conda environments
Expand Down
2 changes: 1 addition & 1 deletion tests/conda_snakedeploy_env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ channels:
- bioconda
dependencies:
- python <3.12 # temporary fix for snakemake issue #2480
- snakemake-minimal
- snakemake-minimal <8 # HACK Snakemake v8 has breaking changes
- snakedeploy
- go-yq
2 changes: 1 addition & 1 deletion tests/conda_test_env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ channels:
- bioconda
#- defaults # see: https://github.com/conda-forge/status/issues/144
dependencies:
- snakemake-minimal
- snakemake-minimal <8 # HACK Snakemake v8 has breaking changes
3 changes: 2 additions & 1 deletion utils/quick_install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ conda config --set channel_priority strict
# NOTE conda-forge *HAS TO* be higher than bioconda

VPIPEENV=
if mamba install --yes snakemake-minimal mamba $GIT; then # NOTE Mac OS X and some Linux dockers don't have git out of the box
# HACK Snakemake v8 has breaking changes
if mamba install --yes 'snakemake-minimal<8' mamba $GIT; then # NOTE Mac OS X and some Linux dockers don't have git out of the box
: # success!
else
oops 'I cannot install snakemake in base environment. Conflicts ?'
Expand Down

0 comments on commit 25fd3a9

Please sign in to comment.