closes #3 by bumping depedencies #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several motivations for this the most important being able to use newer than 1.x ES gem and limiting it to the 2 major gems (some thing might be broken and anyways I would consider this a breaking change). gem deps bumped: - `elasticsearch (['>= 2.0','<= 6.0'])` - `faraday (~> 0.12)` - `faraday_middleware (~> 0.11.0.1)` As part of this just to get everything to work in a modern version of ruby I had to do some other restructuring here are some of the misc changes: - restructured gem lib structure (in order remove lots of require_relatives that were broken in ruby > 2) - made versioning a bit easier to work with Signed-off-by: Ben Abrams <[email protected]>
This was referenced Jun 24, 2017
Open
|
@cdunn any chance of getting this looked at? If not we are probably gonna have to drop support that this gem provides. |
|
If this can not be merged we are looking at a fork, rename, publish or dropping the support of the features this provides entirely by Feb 01 2017. You can read more about it here: sensu-plugins/sensu-plugins-elasticsearch#64 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several motivations for this the most important being able to use newer than 1.x ES gem and limiting it to the 2 major gems (some thing might be broken and anyways I would consider this a breaking change).
gem deps bumped:
elasticsearch (['>= 2.0','<= 6.0'])faraday (~> 0.12)faraday_middleware (~> 0.11.0.1)As part of this just to get everything to work in a modern version of ruby I had to do some other restructuring here are some of the misc changes:
Signed-off-by: Ben Abrams [email protected]