Apply ruff suggestions #1479
Open
Apply ruff suggestions #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B006 Do not use mutable data structures for argument defaults
G010 Logging statement uses `warn` instead of `warning`
B015 Pointless comparison. Did you mean to assign a value?
Otherwise, prepend `assert` or remove it.
B009 Do not call `getattr` with a constant attribute value.
It is not any safer than normal property access.
UP027 Replace unpacked list comprehension with a generator expression
B020 Loop control variable `...` overrides iterable it iterates
E711 Comparison to `None` should be `cond is None` E711 Comparison to `None` should be `cond is not None`
E713 Test for membership should be `not in`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ruff rules apply to Python 2.7 too.
Especially, bugbear rules may uncover real bugs.