Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ruff suggestions #1479

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Apply ruff suggestions #1479

wants to merge 8 commits into from

Commits on Mar 28, 2024

  1. Apply ruff/bugbear suggestion 

    B006 Do not use mutable data structures for argument defaults
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    41e32ce View commit details
    Browse the repository at this point in the history

  2. Apply ruff/flake8-logging-format suggestion 

    G010 Logging statement uses `warn` instead of `warning`
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b5891e9 View commit details
    Browse the repository at this point in the history

  3. Apply ruff/bugbear suggestion 

    B015 Pointless comparison. Did you mean to assign a value?
     Otherwise, prepend `assert` or remove it.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c1e1dbc View commit details
    Browse the repository at this point in the history

  4. Apply ruff/bugbear suggestion 

    B009 Do not call `getattr` with a constant attribute value.
     It is not any safer than normal property access.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4478989 View commit details
    Browse the repository at this point in the history

  5. Apply ruff/pyupgrade suggestion 

    UP027 Replace unpacked list comprehension with a generator expression
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6e2bbe7 View commit details
    Browse the repository at this point in the history

  6. Apply ruff/bugbear suggestions 

    B020 Loop control variable `...` overrides iterable it iterates
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    38974f0 View commit details
    Browse the repository at this point in the history

  7. Apply ruff/pycodestyle suggestion 

    E711 Comparison to `None` should be `cond is None`
E711 Comparison to `None` should be `cond is not None`
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0b74f8b View commit details
    Browse the repository at this point in the history

  8. Apply ruff/pycodestyle suggestion 

    E713 Test for membership should be `not in`
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8bf6281 View commit details
    Browse the repository at this point in the history