Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable signup footer #1317

Merged
merged 2 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/HomePage/HomePageLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { ReactNode } from 'react';
import { AppBarLanding } from '@/components/AppBar';
import { Banner } from '@/components/Banner';
import { Footer } from '@/components/Footer';
import { SignupForm } from '@/components/SignupForm';

interface Props {
children: ReactNode;
Expand All @@ -15,7 +14,8 @@ export function HomePageLayout({ children }: Props) {
<Banner />
<AppBarLanding />
<div className="flex-grow min-h-screen">{children}</div>
<SignupForm variant="home" />
{/* Disabling for now because HubSpot drops cookies */}
{/* <SignupForm variant="home" /> */}
<Footer />
</div>
);
Expand Down
9 changes: 4 additions & 5 deletions frontend/src/components/Layout/Layout.tsx
Original file line number Diff line number Diff line change
@@ -1,26 +1,25 @@
import { useRouter } from 'next/router';
import { ReactNode } from 'react';

import { AppBar } from '@/components/AppBar';
import { Banner } from '@/components/Banner';
import { Footer } from '@/components/Footer';
import { SignupForm } from '@/components/SignupForm';

interface Props {
children: ReactNode;
}

export function Layout({ children }: Props) {
const router = useRouter();
const isSearchPage = router.pathname === '/plugins';
// const router = useRouter();
// const isSearchPage = router.pathname === '/plugins';

return (
<div className="flex flex-col min-h-screen">
<Banner />
<AppBar />

<main className="flex flex-col flex-grow">{children}</main>
<SignupForm variant={isSearchPage ? 'search' : 'default'} />
{/* Disabling for now because HubSpot drops cookies */}
{/* <SignupForm variant={isSearchPage ? 'search' : 'default'} /> */}
<Footer />
</div>
);
Expand Down
Loading