Windows: ensure output is UTF16 encoded when output is not a terminal #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wouldn't make sense to start the renderer on an uninitialized terminl I/O.
Otherwise, the output is gibberish invalid encoded utf16. When using windows.ENABLE_VIRTUAL_TERMINAL_PROCESSING, the output gets converted automatically by Windows Console API. When output is not a terminal, we need to do that ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to transform the output from UTF8 to wide characters UTF16 for Windows to understand when output is not a terminal.