Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: ensure output is UTF16 encoded when output is not a terminal #1064

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Windows: ensure output is UTF16 encoded when output is not a terminal #1064

wants to merge 2 commits into from

Commits on Jul 18, 2024

  1. fix: initialize the terminal before creating the renderer 

    It wouldn't make sense to start the renderer on an uninitialized
terminl I/O.
    @aymanbagabas
    aymanbagabas committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    80b0d90 View commit details
    Browse the repository at this point in the history

  2. feat(windows): ensure output is utf16 wide chars when not a tty 

    Otherwise, the output is gibberish invalid encoded utf16. When using
windows.ENABLE_VIRTUAL_TERMINAL_PROCESSING, the output gets converted
automatically by Windows Console API. When output is not a terminal, we
need to do that ourselves.
    @aymanbagabas
    aymanbagabas committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ca07f34 View commit details
    Browse the repository at this point in the history