Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ipemu probes #703

Merged
merged 2 commits into from
Aug 9, 2024
Merged

refactor ipemu probes #703

merged 2 commits into from
Aug 9, 2024

Conversation

Clo91eaf
Copy link
Contributor

@Clo91eaf Clo91eaf commented Aug 6, 2024 •
edited
Loading

  • refactor probe signatures to improve readability
  • refactor to an single Probe to avoid using Record on the [[T1Interface]].

@Clo91eaf Clo91eaf marked this pull request as draft August 6, 2024 03:34
@Clo91eaf Clo91eaf force-pushed the refactor_t1probe branch 2 times, most recently from 54a69d9 to 4ab033c Compare August 6, 2024 03:45
@Clo91eaf Clo91eaf marked this pull request as ready for review August 6, 2024 05:54
@Clo91eaf Clo91eaf force-pushed the refactor_t1probe branch 2 times, most recently from 7b8eb13 to af7aba8 Compare August 8, 2024 16:31
sequencer
sequencer approved these changes Aug 9, 2024
View reviewed changes
t1/src/T1.scala Show resolved Hide resolved
@sequencer
Copy link
Member

We should adopt layer in a near future.

@sequencer sequencer merged commit 7d0b99f into master Aug 9, 2024
84 checks passed
@sequencer sequencer deleted the refactor_t1probe branch August 9, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sequencer sequencer sequencer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Clo91eaf @sequencer