Adding Umami Analytics Support #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for https://umami.is/ analytics. Signed-off-by: Robert Terakedis <[email protected]>
|
Thanks for this! Looks ok to me, requesting review from @onweru. |
chipzoller
approved these changes
Sep 22, 2024
|
@onweru / @chipzoller - can you merge this when convenient? |
|
Sorry for the long delay and thank you! |
|
Thank you sir!! |
|
<script defer src="https://cloud.umami.is/script.js" data-website-id="{{ . }}"></script>
src should also be changed to configurable, after all, umami is open source and can be deployed by yourself |
|
@blackmady - good point, I’ll submit another PR with a fix in the near future. |
8 tasks
|
@blackmady - Submitted a new PR: #488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for https://umami.is/ analytics.
Pull Request type
Please check the type of change your PR introduces:
Current state
Issue Number(s): Not related to a current issue.
Proposed changes
Add support for Umami analytics. This change adds code to
analytics.htmlpartial (adding the umami script reference),params.toml(for the configuration), andReadme.mdfor the detail on how to configure.Screenshots, if applicable
Checklist
git commit -s ...), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.