Umami Fix to allow self-hosted configurations #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the original code to allow self-hosted configurations. Signed-off-by: Robert Terakedis <[email protected]>
8 tasks
onweru
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the first version of the code to allow self-hosted configurations.
Pull Request type
Please check the type of change your PR introduces:
Current state
Currently, the Umami code in the
analytics.htmlpartial assumes the cloud-hosted umami script URL and is not configurable.Proposed changes
As mentioned in the previous pull request, umami can be self-hosted. This PR intends to fix the original PR by making the script hosting URL configurable.
Screenshots, if applicable
N/A - this is not a visual change. It alters the analytics partial which loads in the
<head>...</head>section of HTML.Checklist
git commit -s ...), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.