(#334) Fix catalog when systemd is not available #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On systems where systemd is not available (e.g. FreeBSD), creating systemd resources even to ensure they are absent cause errors. We should only manage systemd resources if the system has systemd. Rely on the `systemd` fact to determine if systemd is available. This fact is provided by puppet-systemd since version 0.3.0, way older that 5.1.0 currently required. Fixes #334
treydock
reviewed
Jan 7, 2025
| active => $systemd_active, | ||
| enable => $systemd_enable, | ||
| timer_content => epp("mcollective/refresh_facts.timer.epp", { | ||
| if $facts["systemd"] == "systemd" { |
There was a problem hiding this comment.
@smortex FYI this is wrong
$ sudo facter -p systemd
true
This fact is a boolean: https://github.com/voxpupuli/puppet-systemd/blob/58f0075f6926e3efec647f1f4d525e9ed1ad006a/lib/facter/systemd.rb#L41
smortex
added a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems where systemd is not available (e.g. FreeBSD), creating
systemd resources even to ensure they are absent cause errors. We
should only manage systemd resources if the system has systemd.
Rely on the
systemdfact to determine if systemd is available. Thisfact is provided by puppet-systemd since version 0.3.0, way older that
5.1.0 currently required.
Fixes #334