Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facts refreshing when refresh_type=systemd #340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smortex
Copy link
Member

@smortex smortex commented Jan 7, 2025

@treydock reported that an invalid condition was introduced in #335.
This commit fix that.

@smortex
Copy link
Member Author

smortex commented Jan 7, 2025

@treydock can you please confirm that fix your issue?

@smortex smortex added the bug label Jan 7, 2025
@smortex

This comment was marked as outdated.

@treydock
Copy link
Contributor

treydock commented Jan 7, 2025

I think this should work but would take me a bit of time to integrate into our GHE environment. I think this approach is better than using systemd fact since that relies on systemd module which sites without systemd may not use.

@smortex smortex reopened this Jan 7, 2025
@smortex smortex linked an issue Jan 7, 2025 that may be closed by this pull request
@treydock reported that an invalid condition was introduced in #335.
This commit fix that.
@smortex smortex force-pushed the fix-systemd-refresh_type branch from 110c881 to db9869c Compare January 7, 2025 21:30
@treydock
Copy link
Contributor

treydock commented Jan 7, 2025

Verified this works on a host where systemd is the preferred method to deploy the fact refresh timer.

$ sudo facter -p service_provider
systemd

Our r10k config is using this branch and applied to host that had downgraded to 0.14.5 so nothing changed:

$ sudo puppet agent -t --noop
Info: Using environment 'dev_OMIT_11402'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Notice: Requesting catalog from OMIT
Notice: Catalog compiled by OMIT
Info: Applying configuration version 'OMIT::dev_OMIT_11402::edc5b3bc75a8e693cf1fb39f5dbaef71d714541c::::'
Notice: Applied catalog in 49.67 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix systemd fact usage
2 participants