Coreys branch #1
Conversation
…ription key/value pairs
…nd files created by VIM >.<)
…lso added semicolons for linters :P)
…ES7/JSX code to valid ES5 and bundling CSS/JS
…act-Router SPA routing and a Redux wrapper for global state management
…browsers local storage so it persists even after a session expires
…an API that is expected to return JSON data
…t the redux state of a site.
… by an action creator method) and determine how the redux state should be updated
… Also created a fabfile for scripting tasks.
…ader {Content-Type: application/json})
… for user and player actions
|
Looking at split diffs will probably be more helpful than the unified ones, since most of the edits were additions. |
| players = require('./libs/data/players'), | ||
| swig = require('swig'), | ||
| app = express(), | ||
| port = 8080; | ||
|
|
There was a problem hiding this comment.
Its a good practice to chain your declarations as long as you can. Something about how v8 does optimization.
|
|
|
So, I feel like this is just too much stuff to bring in from the get go. Not that all of it isn't valuable. Largely this project is for me to learn some of this new technology stack. I'm not intending on doing any complicated css work at the moment. I was intending on just bring in the http://getskeleton.com/ css library to just do some basic stuff. I'm not sure if I want to bring in a css framework that compiles down to a single css file when I'm largely just wanting to display a single grid on a page. I'd really just like to have a vanilla react application for the front end. Maybe use one of the build tools to generate a single js file to serve to the page. I'd like to boil this down to just basic react, babel for es6 transpiling, and perhaps a build tool that will create a single javascript file for the entire application. |
Ok, I tried to break it up into logical commits as best I could. Just start from the oldest commit and make your way towards the latest. There are a couple of commits that were just for little bug fixes or tweaks. Don't dwell too much on those.
I'll try to add some github comments to help clarify some things.