Node organization #4
Conversation
…y would be included git
| app.set('rootPath', __dirname); | ||
| // Global Paths | ||
| app.set('paths', { | ||
| routes: path.join(app.get('rootPath'), 'routes'), |
There was a problem hiding this comment.
Can you explain a little bit of what is going on here?
There was a problem hiding this comment.
The use of just one const keyword is an optimization trick for v8.
The app.set() functions are creating global values that can be accessed anywhere you have a reference to the app obect.
There was a problem hiding this comment.
Is this like a best practice or something? It seems weird to me to have to pass around the app everywhere. I would think it would be simpler to have each module completely encapsulate all of its requirements.
There was a problem hiding this comment.
No, I just pass it to routes and middlewares so that each module has the option to attach to either the global app or the apiRouter. That way can can do things like write middleware that only applies to certain routers (e.g. auth middleware for api endpoints). I'm not sure how you could write a middleware that applies to all endpoints without passing the app object. Not to say there isn't a way, though.
There was a problem hiding this comment.
I think the way I'm doing that in the existing api_routes would effectively accomplish that same feat. If I wanted something to apply to all api routes, I could just specify app.use('/api', middleware) . Then all calls to the api routes would pass through that middleware right?
| require(route)(app, apiRouter); | ||
| }); | ||
|
|
||
| app.use('/api', apiRouter); | ||
|
|
||
| app.get('/users', function(request, response) { | ||
|
|
There was a problem hiding this comment.
I didn't put these guys in their own module yet, because I wasn't sure what your plan is with them.
There was a problem hiding this comment.
Those were just some garbage I threw together as an example. I'd actually go ahead and remove them at some point.
…er isn't accessible
|
Went ahead and removed the user endpoints. And I changed the static folder to something other than root. That way all of the node code and config files aren't served. |
Organized the routes so that its easier to add new ones and added a directory for middleware. Also, did a few cleanup things.