Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(ext/cfx-ui): Hide sv_poolSizesIncrease ConVar #2867

Merged

Conversation

tens0rfl0w
Copy link
Contributor

Goal of this PR

Showing this information to the end-user isn't really helpful, so we hide it.
image

How is this PR achieving the goal

Adding an exception for "sv_poolSizesIncrease" in the server info aggregation function.

This PR applies to the following area(s)

cfx-ui

Successfully tested on

Game builds: Not applicable

Platforms: Windows (Client)

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

/

This hides the recently introduced sv_poolSizesIncrease ConVar in the server info view
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Oct 16, 2024
@martonp96 martonp96 added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Oct 16, 2024
@martonp96 martonp96 self-requested a review October 16, 2024 18:13
@prikolium-cfx prikolium-cfx merged commit 0855e6f into citizenfx:master Oct 21, 2024
3 checks passed
@tens0rfl0w tens0rfl0w deleted the tweak/cfx-ui/hide-poolsize-convar branch October 21, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants