Bugfix: cannot start http server #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server cannot be started because the spring `NamespaceHandler` cannot be found. Adding the container descriptor handler resolves the issue. This is the workaround mentioned in citrusframework#2 (comment), moved to the default descriptors.
We want to copy the logs from the citrus container before the maven execution fails. This makes it necessary to split the execution and verification of the citrus tests into different maven phases, so we can "move" the execution of docker:copy, docker:stop and docker:remove "between" test execution and test verification.
In the current implementation, citrus-remote:test and docker:copy are executed within the same stage. This makes the order of execution dependent on the plugin order within the pom.xml. By providing a separate stage (post-integration-test), the only critical part is that docker:copy is executed before docker:stop and docker:remove. This makes the order of execution still dependent on the order in which the executions in the docker plugin are defined, but only within the same plugin.
🚦Reports 🚦Reports will be posted here as they get available. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2.
Add container descriptor handler for spring boot's meta inf.
The server cannot be started because the spring
NamespaceHandlercannot be found. Adding the container descriptor handler resolves the issue.This is the workaround mentioned in #2 (comment), moved to the default descriptors.