Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: cannot start http server #13

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Bugfix: cannot start http server #13

merged 3 commits into from
Sep 6, 2024

Commits on Sep 5, 2024

  1. #2: Add container descriptor handler for spring boot's meta inf. 

    The server cannot be started because the spring `NamespaceHandler` cannot be found. Adding the container descriptor handler resolves the issue.

This is the workaround mentioned in citrusframework#2 (comment), moved to the default descriptors.
    @turing85
    turing85 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6f0ae06 View commit details
    Browse the repository at this point in the history

  2. Refactoring: Move verification of citrus test in phase "verify". 

    We want to copy the logs from the citrus container before the maven execution fails. This makes it necessary to split the execution and verification of the citrus tests into different maven phases, so we can "move" the execution of docker:copy, docker:stop and docker:remove "between" test execution and test verification.
    @turing85
    turing85 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c87ab1e View commit details
    Browse the repository at this point in the history

  3. Refactoring: Give the docker:copy execution a separate stage. 

    In the current implementation, citrus-remote:test and docker:copy are executed within the same stage. This makes the order of execution dependent on the plugin order within the pom.xml. By providing a separate stage (post-integration-test), the only critical part is that docker:copy is executed before docker:stop and docker:remove. This makes the order of execution still dependent on the order in which the executions in the docker plugin are defined, but only within the same plugin.
    @turing85
    turing85 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    cda71a6 View commit details
    Browse the repository at this point in the history