applying new behaviour to api

lib/ppr_api_web/controllers/api/residential_sale_controller.ex

@@ -5,8 +5,32 @@ defmodule PprApiWeb.API.ResidentialSaleController do
 
   action_fallback PprApiWeb.FallbackController
 
-  def index(conn, _params) do
-    residential_sales = ResidentialSales.list_residential_sales(limit: 100)
-    render(conn, :index, residential_sales: residential_sales)
+  def index(conn, params) do
+    opts =
+      params
+      |> parse_params()
+
+    %{entries: entries, metadata: metadata} =
+      ResidentialSales.list_residential_sales(opts)
+
+    render(conn, :index, entries: entries, metadata: metadata)
+  end
+
+  defp parse_params(params) do
+    defaults = %{
+      "sort" => "date-desc",
+      "before" => nil,
+      "after" => nil,
+      "limit" => 250
+    }
+
+    defaults
+    |> Map.merge(Map.take(params, Map.keys(defaults)))
+    |> Enum.reject(fn
+      {_key, nil} -> true
+      {_key, value} when is_binary(value) -> String.trim(value) == ""
+      {_key, _value} -> false
+    end)
+    |> Enum.into(%{})
   end
 end

lib/ppr_api_web/controllers/api/residential_sale_json.ex

@@ -4,25 +4,20 @@ defmodule PprApiWeb.API.ResidentialSaleJSON do
   @doc """
   Renders a list of residential_sales.
   """
-  def index(%{residential_sales: residential_sales}) do
-    %{data: for(residential_sale <- residential_sales, do: data(residential_sale))}
-  end
-
-  @doc """
-  Renders a single residential_sale.
-  """
-  def show(%{residential_sale: residential_sale}) do
-    %{data: data(residential_sale)}
+  def index(%{entries: residential_sales, metadata: metadata}) do
+    %{
+      data: for(residential_sale <- residential_sales, do: data(residential_sale)),
+      metadata: metadata
+    }
   end
 
   defp data(%ResidentialSale{} = residential_sale) do
     %{
-      id: residential_sale.id,
       date_of_sale: residential_sale.date_of_sale,
       address: residential_sale.address,
       county: residential_sale.county,
       eircode: residential_sale.eircode,
-      price_in_euros: residential_sale.price_in_euros,
+      price_in_euros: residential_sale.price_in_euros |> Decimal.to_string(),
       not_full_market_price: residential_sale.not_full_market_price,
       vat_exclusive: residential_sale.vat_exclusive,
       description_of_property: residential_sale.description_of_property,

lib/ppr_api_web/router.ex

@@ -16,7 +16,6 @@ defmodule PprApiWeb.Router do
 
   scope "/api/v1", PprApiWeb do
     pipe_through :api
-
     resources "/residential/sales", API.ResidentialSaleController
   end