Add additional controllers #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
civerachb-cpr
force-pushed
the
more-controllers
branch
from
77315d1 to
1eea89d
Compare
civerachb-cpr
force-pushed
the
more-controllers
branch
from
1eea89d to
a8330fc
Compare
civerachb-cpr
requested review from
mhosmar-cpr and
roni-kreinin
and removed request for
a team
| LOGITECH = 'logitech' | ||
| XBOX = 'xbox' |
There was a problem hiding this comment.
Should this be generic to any xbox controller, or are there different versions?
There was a problem hiding this comment.
As far as I'm aware there is only one model of Xbox controller.
mhosmar-cpr
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional allowed values for the
platform/controllerparameter.See clearpathrobotics/clearpath_common#131