Revert trunk branch versions to 1.0.0-rc3 (no hotfix)
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
changed the title
1.0.0-rc3 (no hotfix)
cloutiertyler
approved these changes
Jan 27, 2025
bfops
added a commit
that referenced
this pull request
Jan 27, 2025
## Description of Changes Revert DLLs, which I should have done in #223. See that PR for background on why it was necessary. ## API - [ ] This is an API breaking change to the SDK Kinda, but it's a revert. ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* ## Testsuite SpacetimeDB branch name: master ## Testing I would have liked to say that the current CI is sufficient as I did in the last PR, but now I no longer feel confident.. Currently the repo is in a somewhat inconsistent state, though, so I think we should merge this right now as it will not make it _less_ consistent. I'm very open to suggestions about how to test this properly. Co-authored-by: Zeke Foppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Remove the
-hotfix*part of the version in our trunk branch.It was a (my) mistake to merge a
-hotfix*version change. Hotfixes are, by definition, cherry-picked changes that are going to be released directly to users without merging.The consequence of merging this change was that the
SDK TestsCI job started failing on SpacetimeDB PRs (e.g. see failures on clockworklabs/SpacetimeDB#2137), because it checks out this repo, which then tried to use the-hotifx3version of SpacetimeDB. But themasterbranch of SpacetimeDB is at1.0.0-rc3(no hotfix), because the hotfix was correctly released from a branch without merging in that repo.Although this PR reverts the version change, we do still have a tag
v1.0.0-rc3-hotfix3that we can use to release the hotfix version (bygit push -f origin v1.0.0-rc3-hotfix3:master) if/when desired.API
No
Requires SpacetimeDB PRs
Should work with
master.Testsuite
If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.
SpacetimeDB branch name: master
Testing
I claim that the CI tests passing with
mastershow that this is correct. The original version change itself passed CI because it was pointing at a non-masterbranch for testing. I claim it would have failed if it were tested against SpacetimeDBmaster.Generally, this might point to a bug in how we've done this CI: We should probably only allow a PR to merge in this repo if it tests successfully against SpacetimeDB
master, even if we want to point it at other branches to test in the meantime.