Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust http api usage for glowup #242

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Adjust http api usage for glowup #242

merged 2 commits into from
Feb 11, 2025

Conversation

coolreader18
Copy link

@coolreader18 coolreader18 commented Feb 7, 2025

Description of Changes

Companion PR for the http api glowup.

API

Not a breaking change; this catches us up to being compatible with a breakage introduced by

Requires SpacetimeDB PRs

Testsuite

SpacetimeDB branch name: master

Testing

Existing CI passes (it was failing without this change since it couldn't connect).

@bfops bfops mentioned this pull request Feb 11, 2025
@bfops bfops changed the base branch from master to staging February 11, 2025 18:12
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes, this seems good to me!

@bfops bfops enabled auto-merge (squash) February 11, 2025 18:19
@bfops bfops merged commit 19c3e75 into staging Feb 11, 2025
9 checks passed
@bfops bfops deleted the noa/http-glowup branch February 11, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants