-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(wrangler): refine the type of buildOptions #7876
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-wrangler-7876 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7876/npm-package-wrangler-7876 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-wrangler-7876 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-workers-bindings-extension-7876 -O ./cloudflare-workers-bindings-extension.0.0.0-v93cccae5f.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v93cccae5f.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-create-cloudflare-7876 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-kv-asset-handler-7876 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-miniflare-7876 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-pages-shared-7876 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-unenv-preset-7876 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-vite-plugin-7876 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-vitest-pool-workers-7876 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-workers-editor-shared-7876 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-workers-shared-7876 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12957249221/npm-package-cloudflare-workflows-shared-7876 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
941ed67
to
e6b6245
Compare
Minor change I figured out while exploring metafiles - my idea is to have an options to expose them so that users can get info about their bundle content.
The change:
Before this PR, we had:
Because the type of result depends on
typeof buildOptions
, we had to add& { metafile: true }
so that the metafile specific props are exposed on the result.This PR switches to:
So that
typeof buildOptions
is notesbuild.BuildOptions
but it's actual type and thenmetafile: true
is inferred from the actual value.There are multiple other properties on
result
depending on the actual type of the options, so this minor change is a nice thing to have.