Remove distinct for service plan list queries
#3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johha
force-pushed
the
service-plans-distinct
branch
2 times, most recently
from
6f49080 to
3ac5e20
Compare
Service plans (and service offerings) can have multiple sources depending on the query parameters, user permissions and service plan visibilities. To ensure uniqueness and avoid duplicates we used `distinct` in the SQL queries. However existing validators already ensure that there cannot be any duplicates. Thus: - `distinct` can be removed to improve SQL performance - introduce a new validation in `service_plan_visibility` ensures that a public plan cannot be associated with a `service_plan_visibility` - implement a test case to make sure the validation works as expected and throws proper error message
johha
force-pushed
the
service-plans-distinct
branch
from
3ac5e20 to
6f0d2eb
Compare
philippthun
approved these changes
Jan 31, 2024
philippthun
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Feb 23, 2024
As part of PR cloudfoundry#3620 [1] it has been validated that there is no overlap between the different sources (UNIONed datasets). But as these single datasets are created by JOINing several tables, there might be duplicates depending on the cardinality of those relations. Thus the overall DISTINCT is replaced by DISTINCTs added when JOINing a table with a one-to-many relation. Calling '.distinct' multiple times does not have any negative effect as this simply sets a flag on the Sequel dataset. This change should improve performance of requests to the following endpoints whenever those JOINs are not needed (e.g. depending on request parameters): - /v3/service_offerings - /v3/service_plans Tests now ensure that there are: - multiple plans per offering - multiple service instances per plan - multiple visibilities per plan - multiple spaces per organization [1] cloudfoundry#3620
5 tasks
philippthun
added a commit
that referenced
this pull request
Apr 16, 2024
As part of PR #3620 [1] it has been validated that there is no overlap between the different sources (UNIONed datasets). But as these single datasets are created by JOINing several tables, there might be duplicates depending on the cardinality of those relations. Thus the overall DISTINCT is replaced by DISTINCTs added when JOINing a table with a one-to-many relation. Calling '.distinct' multiple times does not have any negative effect as this simply sets a flag on the Sequel dataset. This change should improve performance of requests to the following endpoints whenever those JOINs are not needed (e.g. depending on request parameters): - /v3/service_offerings - /v3/service_plans Tests now ensure that there are: - multiple plans per offering - multiple service instances per plan - multiple visibilities per plan - multiple spaces per organization [1] #3620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service plans (and service offerings) can have multiple sources depending on the query parameters, user permissions and service plan visibilities. To ensure uniqueness and avoid duplicates we used
distinctin the SQL queries. However existing validators already ensure that there cannot be any duplicates.Thus:
distinctcan be removed to improve SQL performanceservice_plan_visibilityensures that a public plan cannot be associated with aservice_plan_visibilityI have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests