Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spa-s3-cloudfront: Lambda@Edge Error Handling #948

Closed
wants to merge 4 commits into from
Closed

spa-s3-cloudfront: Lambda@Edge Error Handling #948

wants to merge 4 commits into from

Conversation

milldr
Copy link
Member

@milldr milldr commented Jan 8, 2024

what

  • Upstreaming latest lambda @ edge for the spa-s3-cloudfront component

why

  • This update helps track 403 and 404 errors for these lambda functions

references

@milldr milldr requested review from a team as code owners January 8, 2024 23:53
Nuru
Nuru requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of documentation changes requested.

How about we create separate responses for 403 and 404 errors, make them configurable via inputs, and default both to 404.html for backward compatibility. Is that too big a lift for today?

milldr and others added 2 commits January 8, 2024 17:01
@milldr milldr mentioned this pull request Feb 7, 2024
Merged
@milldr
Copy link
Member Author

milldr commented Feb 7, 2024

replaced by #978

@milldr milldr closed this Feb 7, 2024
@goruha goruha deleted the spa-lambda-upstream branch November 1, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru requested changes

@max-lobur max-lobur max-lobur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milldr @Nuru @max-lobur