Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Lambda@Edge for spa-s3-cloudfront #978

Merged
merged 10 commits into from
Feb 8, 2024
Merged

Refactor Lambda@Edge for spa-s3-cloudfront #978

merged 10 commits into from
Feb 8, 2024

Conversation

milldr
Copy link
Member

@milldr milldr commented Feb 7, 2024 •
edited
Loading

what

  • Refactored the spa-s3-cloudfront component
  • Remove all Lambda@Edge submodules; replaced by a single file lambda_edge.tf

why

  • We've introduced the paywall lambda@edge functions. However, these functions are specific to the cloudposse docs authentication process and should not be included with other spa deployments.
  • The submodules for lambda@edge overly complicated the resources required. Instead, we can use a single module and pass the functions we need
  • We are not converting these functions to CloudFront Functions at this time. We have another follow-up, backlog task for that effort. Not critical at the moment

references

@milldr milldr mentioned this pull request Feb 7, 2024
Closed
@milldr milldr marked this pull request as ready for review February 7, 2024 21:39
@milldr milldr requested review from a team as code owners February 7, 2024 21:39
aknysh
aknysh reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nitpicks

@milldr milldr merged commit 7b2f215 into main Feb 8, 2024
5 checks passed
@milldr milldr deleted the refactor-spa-s3-cloudfront branch February 8, 2024 17:30
goruha pushed a commit to cloudposse-terraform-components/aws-spa-s3-cloudfront that referenced this pull request Nov 27, 2024
@milldr @aknysh @cloudpossebot
Refactor Lambda@Edge for spa-s3-cloudfront (cloudposse/terraform-aw…
322ba4a 
…s-components#978)

Co-authored-by: Andriy Knysh <[email protected]>
Co-authored-by: cloudpossebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milldr @aknysh @cloudpossebot