fix: Increase input clear button target size to 24×24 pixels #3253
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashbot
force-pushed
the
button-touch-target
branch
from
cd61c28 to
69ca340
Compare
avinashbot
force-pushed
the
button-touch-target
branch
from
69ca340 to
15592ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3253 +/- ##
========================================
Coverage 96.44% 96.44%
========================================
Files 791 791
Lines 22568 22569 +1
Branches 7385 7733 +348
========================================
+ Hits 21765 21766 +1
+ Misses 796 750 -46
- Partials 7 53 +46 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not sold on this yet, but it does work. We don't have to update all "inline-icon" buttons, just the ones that are within 24px of another interactive control. In this case, the clear button is on top of the input element, so we're literally 0px away from the nearest interactive control.
Related links, issue #, if available: AWSUI-60212
How has this been tested?
Should be visually identical. Just pushed to my dev branch, and everything looks good.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.