fix: Fix flaky integration test for table with inline editing #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-kot
commented
Jan 17, 2024
| @@ -43,7 +43,6 @@ export default class TableEditablePageObject extends TableFilteringPageObject { | |||
| const bodyCell = this.tableWrapper.findBodyCell(row, 4); | |||
| const input = bodyCell.findFormField().find('input'); | |||
| await this.click(bodyCell.toSelector()); | |||
There was a problem hiding this comment.
When the editable cell is clicked the input is auto-focused. A second click to the input is unnecessary and sometimes leads to the text cursor position change: it moves from behind the last symbol to the middle of the visible input area. That breaks the input cleanup code from below that relies on the cursor position.
Al-Dani
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a flaky test, see description in comments.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.