Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix flaky integration test for table with inline editing #113

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: Fix flaky integration test for table with inline editing #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/e2e/page/table-editable-page-object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export default class TableEditablePageObject extends TableFilteringPageObject {
const bodyCell = this.tableWrapper.findBodyCell(row, 4);
const input = bodyCell.findFormField().find('input');
await this.click(bodyCell.toSelector());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the editable cell is clicked the input is auto-focused. A second click to the input is unnecessary and sometimes leads to the text cursor position change: it moves from behind the last symbol to the middle of the visible input area. That breaks the input cleanup code from below that relies on the cursor position.

await this.click(input.toSelector());

const current = await this.browser.$(input.toSelector()).getValue();
const backspaces = Array(current.length).fill('Backspace');
Expand Down
Loading