Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys,roachpb: change default system tenant from tenantID {1} to {2} #133926

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

sql,ua: include sequences for copy

45ccd6c
Select commit
Loading
Failed to load commit list.
Draft

keys,roachpb: change default system tenant from tenantID {1} to {2} #133926

sql,ua: include sequences for copy
45ccd6c
Select commit
Loading
Failed to load commit list.
blathers[crl] / blathers/lint-epic-issue-refs failed Nov 15, 2024 in 0s

Epic and issue reference check failed

PRs must contain a valid issue or epic reference.

Details

When multiple epics are referenced in the PR body, each commit of the PR should reference the epic(s) that commit is part of and all epics listed in the commit messages should be listed in the PR body. These unexpected cases were found:
Error 1: Neither the PR body nor any of the commits in this PR contain a valid issue or epic reference. Please add one.

Recommended reference placement:

If the PR relates to only one issue or Jira epic:

  • Put the issue or Jira epic reference either in the PR description or in each relevant commit.
  • If the reference is in the PR description, put Epic: None in each commit that doesn't relate to the epic. This is particularly important if the commit contains a release note.
    If the PR relates to multiple issues or Jira epics:
  • Put the issue or Jira epic reference in each relevant commit.
  • If a single commit relates to multiple Jira epics, put all relevant issue or Jira epic references in that commit.
  • If all commits relate to all the Jira epics, put the issue or Jira epic references in the PR description or in all of the commit messages.
  • Put Epic: None in each commit that doesn't relate to any issue or epic.
    If the PR relates to no issues and no Jira epics:
  • Preferably, put Epic: None in the PR description or in each commit containing a release note.

Supported Issue Identifiers:

For more information about issue and epic references, see: https://wiki.crdb.io/wiki/spaces/CRDB/pages/2009039063/