Triggers docs, syntax, limitations #19129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
taroface
force-pushed
the
triggers
branch
4 times, most recently
from
918eb08 to
0b8d3e2
Compare
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Nov 13, 2024
135051: docgen: update SQL diagrams for triggers r=DrewKimball a=taroface Made updates to the CREATE TRIGGER and DROP TRIGGER SQL diagrams. These will be used with the docs added in cockroachdb/docs#19129 The generated diagrams:   Epic: none Release note: none Release justification: non-production code change Co-authored-by: Ryan Kuo <[email protected]>
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Nov 13, 2024
134886: roachtest: split perturbation/* tests r=kvoli a=andrewbaptist This commit splits all the individual perturbations into separate files. This will make it easier to find and update a perturbation. Epic: none Release note: None 135051: docgen: update SQL diagrams for triggers r=DrewKimball a=taroface Made updates to the CREATE TRIGGER and DROP TRIGGER SQL diagrams. These will be used with the docs added in cockroachdb/docs#19129 The generated diagrams:   Epic: none Release note: none Release justification: non-production code change Co-authored-by: Andrew Baptist <[email protected]> Co-authored-by: Ryan Kuo <[email protected]>
DrewKimball
reviewed
Nov 13, 2024
src/current/_includes/v24.3/known-limitations/trigger-limitations.md
Outdated
Show resolved
Hide resolved
|
@DrewKimball Addressed your comments & had a follow-up question -- PTAL! |
florence-crl
approved these changes
Nov 14, 2024
Co-authored-by: Florence Morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-10438
DOC-11539
DOC-11590
DOC-11681
Note that the CREATE/DROP TRIGGER SQL diagrams will not match the docs until cockroachdb/cockroach#135051 merges.