'Fit To Window' Player button

[D-Rekk]

New button to toggle 'Fit To Window' player size.

This is a 'Fit To Window' toggle (part of #1445).

• Allows to quickly swap the current Player Size to Old Alternative – Fit To Window
• Works in both Default View and Theater mode. Tested with Comments -> Sidebar enabled
• Icon stolen taken from lucide-icons IIRC

There's possibly bugs with other settings I haven't tested yet

[ImprovedTube]

hey! <3 great!

player size:

• 1.) Fit to window had the goal to increase the video width & height (as much as possible, in ratio)
• 2.) Full window, meant to do the same - but also stretch the player beyond the video's ratio, just to have the player's black background everywhere. (renamed it: Full height because that's the correct description for now)
• later we made them run without theater-mode, just in case width becomes available, when the user hides the sidebar.
  • bug: this video width doesn't increase with hidden sidebar anymore.
  • also, both feature never removed the page margins left & right (to win extra width for the video)
    • So Max width adds CSS for this too
      • However a little code is missing to ensure that the controls bar also increases in width (might stays static in width )
        • Max width is based on a copy of 2. Full height, just because in this combination it would also stretch the controls bar maybe, while combined with "1." it didn't seem to at all.
        • So instead, to make sense, we need to call the features:
          

          1.) max. video width "Fit to page"
          options to select: [always | player-button #556]

          
          - Q: maybe you know how to do this after you already cared so much for player size?
          

          2.) Full Player height
          options to select: [in theater-mode | always | can keep a button too, yet different icon with vertical arrow?]

          - ( + and more options for the youtube header: hide in theater mode|hover in theater mode )

Previously, Player size bugs: #1602

---

• aand this deserves a shortcut shortcut.js and/or chrome://extensions/shortcuts) (just like several existing & future features )

[ImprovedTube]

reverting for troubleshooting for today ( will even do that when it seems the chance is less than 1% that a PR is any related to current issues, if those issue are big enough.)

• undefined css values will can remove the player
  height: calc(var(--it-player-size)

  • so our code rather needs height: calc(var(--it-player-size, 100vh)
    • 2321195

• the following CSS should be conditional(?)

  • 626616c

@D-Rekk

• if you are convinced about the rest i re-revert already

  • e6470d5

• the only bug i found is the player disappearing (undefined size) when i click the your button twice

[D-Rekk]

I didn't get any bug you described until I remembered the CSS trick we added while working on the Comments -> Sidebar feature #1681. Basically "do_not_change" doesn't get applied by default, only when users change the Player Size at least one time. I should add a nullish operator here:
let previousSize = ImprovedTube.storage.player_size === "fit_to_window" ? "do_not_change" : (ImprovedTube.storage.player_size ?? "do_not_change")

[ImprovedTube]

thanks, oh, right - and we / somebody can work on that (#1685)