Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): improve plugin filter option validation #820

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

hanna-skryl
Copy link
Collaborator

Fixes #565

  • Ensure warnings for invalid plugin filter options are logged regardless of the --verbose flag.
  • Improve message clarity by handling both singular and plural cases.
  • Update unit tests to reflect changes in logging behavior and message wording.

@hanna-skryl hanna-skryl self-assigned this Sep 19, 2024
@github-actions github-actions bot added the 🔬 testing writing tests label Sep 19, 2024
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 17f4120 with source commit 29c39ef.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 46 🟡 51 ↑ +5.1
Security 🟡 89 🟡 88 ↓ −0.8
Code coverage 🟡 90 🟡 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 1 audit regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 46 🟡 51 ↑ +5.1
JS Packages NPM audit 🟡 89 🟡 88 ↓ −0.8
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 6.7 s 🟨 5.5 s ↓ −18.4 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟨 2.9 s ↓ −14.4 %
Lighthouse First Meaningful Paint 🟨 3.3 s 🟨 2.9 s ↓ −14.4 %
Lighthouse Largest Contentful Paint 🟨 3.9 s 🟨 3.6 s ↓ −6.7 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 11 vulnerabilities (3 high, 8 moderate) 🟥 12 vulnerabilities (3 high, 9 moderate) ↑ +9.1 %
Lighthouse Time to Interactive 🟥 16.9 s 🟥 15.5 s ↓ −8 %
Code coverage Branch coverage 🟨 85 % 🟨 85 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 23.1 s 🟥 17.4 s ↓ −24.8 %
Lighthouse Total Blocking Time 🟥 8,680 ms 🟥 5,530 ms ↓ −36.3 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,840 KiB 🟩 Total size was 1,838 KiB ↓ −0.1 %
Lighthouse JavaScript execution time 🟥 10.7 s 🟥 8.4 s ↓ −21.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −8 %
Lighthouse Max Potential First Input Delay 🟥 3,490 ms 🟥 2,720 ms ↓ −22 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,530 ms 🟥 Potential savings of 870 ms ↓ −43.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 106 KiB 🟥 Potential savings of 106 KiB ↑ +50 %
Lighthouse Server Backend Latencies 🟩 220 ms 🟩 170 ms ↓ −23.9 %
Lighthouse Initial server response time was short 🟩 Root document took 380 ms 🟩 Root document took 340 ms ↓ −10.3 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 50 ms ↑ +96.3 %
Code coverage Line coverage 🟩 91.9 % 🟩 91.9 % ↓ −0.1 %

493 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review September 19, 2024 21:04
@hanna-skryl hanna-skryl merged commit 7948333 into main Sep 24, 2024
15 of 18 checks passed
@hanna-skryl hanna-skryl deleted the refactor/plugin-filter-option-validation branch September 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If --onlyPlugins filters out all plugins an empty result shows without a warning
2 participants