Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): merge skip and only plugin filters #822

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

hanna-skryl
Copy link
Collaborator

@hanna-skryl hanna-skryl commented Sep 24, 2024

Follow-up to PR #820 that removed the verbose flag from the missingPlugins.length > 0 condition in validatePluginFilterOption. The change revealed an error in the e2e tests that was previously hidden.

Key changes

  • Merge the skipPluginsMiddleware and onlyPluginsMiddleware into a single filterPluginsMiddleware to handle both filters in one place.
  • Ensure that onlyPlugins and skipPlugins are processed without conflicts.
  • Verify that the logic properly handles cases where both or neither of the filters are provided, preventing issues like missing plugin warnings.

This change ensures more consistent behavior when both skipPlugins and onlyPlugins are used together and resolves local e2e test issues related to package versions.

Copy link

github-actions bot commented Sep 24, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit b15c1a9 with source commit f6f82ed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 46 🟡 53 ↑ +6.8
Code coverage 🟡 90 🟡 90 ↓ −0.1
Custom checks 🟡 67 🟡 67
Security 🟡 87 🟡 87
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 3 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 46 🟡 53 ↑ +6.8
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.3 s 🟨 2.6 s ↓ −21 %
Lighthouse First Meaningful Paint 🟨 3.4 s 🟨 2.6 s ↓ −22.7 %
Lighthouse Largest Contentful Paint 🟨 3.9 s 🟨 3.4 s ↓ −12 %
Lighthouse Speed Index 🟥 6.3 s 🟨 5.7 s ↓ −9.7 %
Lighthouse Time to Interactive 🟥 16.9 s 🟥 16.0 s ↓ −5.7 %
Code coverage Branch coverage 🟨 85 % 🟨 84.9 % ↓ −0.1 %
Code coverage Line coverage 🟩 91.9 % 🟩 91.9 % ↓ −0.1 %
Code coverage Function coverage 🟩 92.2 % 🟩 92.1 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,826 KiB 🟩 Total size was 1,821 KiB ↓ −0.3 %
Lighthouse Minimizes main-thread work 🟥 21.4 s 🟥 19.0 s ↓ −11.4 %
Lighthouse JavaScript execution time 🟥 10.1 s 🟥 9.1 s ↓ −9.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −5.7 %
Lighthouse Total Blocking Time 🟥 7,450 ms 🟥 6,640 ms ↓ −10.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,270 ms 🟥 Potential savings of 490 ms ↓ −61.9 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 60 ms ↑ +160.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 71 KiB 🟥 Potential savings of 71 KiB ↑ +3.3 %
Lighthouse Max Potential First Input Delay 🟥 3,150 ms 🟥 3,150 ms ↑ +0.3 %
Lighthouse Server Backend Latencies 🟩 160 ms 🟩 160 ms ↑ +3.3 %
Lighthouse Avoids an excessive DOM size 🟥 2,255 elements 🟥 2,254 elements ↓ −0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 380 ms 🟩 Root document took 380 ms ↓ −0.1 %

492 other audits are unchanged.

@hanna-skryl hanna-skryl force-pushed the refactor/plugin-filter-option-validation branch from 322d4ce to 5339d32 Compare September 24, 2024 20:19
@hanna-skryl hanna-skryl marked this pull request as ready for review September 24, 2024 20:30
@hanna-skryl hanna-skryl merged commit df5c5ac into main Sep 25, 2024
17 checks passed
@hanna-skryl hanna-skryl deleted the refactor/plugin-filter-option-validation branch September 25, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants