-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add skip and only category filters #831
Conversation
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit b278d14 with source commit 9d75682. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
493 other audits are unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you generalized the {only|skip}{Plugins|Categories}
options into a single implementation, nice work 👍
Closes #610 closes #611
This pull request adds two new CLI flags,
--skipCategories
and--onlyCategories
, to extend the filtering capabilities of the CLI, allowing users to skip or execute only specific categories.The existing
filterPluginsMiddleware
has been renamed tofilterMiddleware
as it now handles filtering for both plugins and categories in a unified manner. This ensures that all validation and filtering logic happens in the same place.The user is notified about skipped or included categories in the same way as they are notified about skipped or included plugins, maintaining a consistent user experience across both filtering options.