Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tap #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: update tap #9

wants to merge 2 commits into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Nov 15, 2023

this builds on #8 so land that first

this update of tap does introduce some breaking changes, however it appears that most of them don't have any impact for us.

an upgrade guide exists here: https://node-tap.org/upgrading-from-16/

most notably, the tap property needs to be removed from package.json. in some cases it may stay, but the format possibly changed. the new defaults for the settings that were previously in this skeleton are what we want to use.

another significant change is that tap no longer uses istanbul for coverage, instead it uses c8. due to this, any lines of coverage that are skipped currently will need the comments skipping them to be updated to the c8 style of ignoring. this is documented here: https://github.com/bcoe/c8#ignoring-uncovered-lines-functions-and-blocks

THIS IS BLOCKED, DO NOT MERGE
see TypeStrong/ts-node#2009

once this lands, or another solution is arrived at, we can do this update. until then we can't since we should all be on node 18

jacobheun
jacobheun previously approved these changes Nov 16, 2023
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussions, project specific overrides in .taprc should do the trick.

Comment on lines -50 to -53
"tap": {
"coverage": true,
"ts": true
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this somehow address the current 100% test coverage threshold expected ? ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not. config has changed in the latest tap so these settings will cause it to throw an error. 100% coverage is the default now. if you need to lower the threshold you can create a .taprc file with

allow-incomplete-coverage: true

i'll make sure the .gitignore template gets updated to keep .taprc files too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants