Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update tap #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −16
Open

feat: update tap #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7334da
chore: update typescript-eslint deps
nlf Nov 15, 2023
e815748
feat: update tap
nlf Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,22 +47,18 @@ export default async function (root: string, variables: Variables) {
"skeleton:apply": `${csBin} apply`,
"skeleton:verify": `${csBin} verify`,
},
tap: {
coverage: true,
ts: true,
},
types: "lib/index.d.ts",
devDependencies: {
"@tsconfig/node18": "^18.0.0",
"@types/node": "^18.0.0",
"@types/tap": "^15.0.0",
"@typescript-eslint/eslint-plugin": "^5.0.0",
"@typescript-eslint/parser": "^5.0.0",
"@typescript-eslint/eslint-plugin": "^6.0.0",
"@typescript-eslint/parser": "^6.0.0",
"eslint": "^8.0.0",
"tap": "^16.0.0",
"tap": "^18.0.0",
"ts-node": "^10.0.0",
"typescript": "^5.0.0"
},
removeDependencies: ["@types/tap"],
}),
"tsconfig.json": json({
set: {
Expand Down
11 changes: 3 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@
"@tsconfig/node18": "^18.0.0",
"@types/mustache": "^4.0.0",
"@types/node": "^18.0.0",
"@types/tap": "^15.0.0",
"@typescript-eslint/eslint-plugin": "^5.0.0",
"@typescript-eslint/parser": "^5.0.0",
"@typescript-eslint/eslint-plugin": "^6.0.0",
"@typescript-eslint/parser": "^6.0.0",
"eslint": "^8.0.0",
"tap": "^16.0.0",
"tap": "^18.0.0",
"ts-node": "^10.0.0",
"typescript": "^5.0.0"
},
Expand All @@ -47,10 +46,6 @@
}
},
"//": "This file is partially managed by code-skeleton. Changes may be overwritten.",
"tap": {
"coverage": true,
"ts": true
},
Comment on lines -50 to -53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this somehow address the current 100% test coverage threshold expected ? ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not. config has changed in the latest tap so these settings will cause it to throw an error. 100% coverage is the default now. if you need to lower the threshold you can create a .taprc file with

allow-incomplete-coverage: true

i'll make sure the .gitignore template gets updated to keep .taprc files too

"types": "lib/index.d.ts",
"files": [
"bin/**/*.js",
Expand Down
Loading