Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint関連パッケージを更新 #476

Merged
merged 19 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,16 @@ module.exports = {
'keyword-spacing': 2,
'camelcase': 0,
},
overrides: [
{
files: [
'layouts/*.vue',
'pages/*.vue'
],
rules: {
// 1単語のコンポーネント名を許容
'vue/multi-word-component-names': 'off'
}
}
]
}
1 change: 1 addition & 0 deletions components/Logo.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<!-- eslint-disable vue/multi-word-component-names -->
<template lang="pug">
<div class="VueToNuxtLogo">
<div class="Triangle Triangle--two" />
Expand Down
1 change: 1 addition & 0 deletions components/Modal.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<!-- eslint-disable vue/multi-word-component-names -->
<template lang="pug">
div
.modal(v-bind:class='{open: isOpen}')
Expand Down
3 changes: 3 additions & 0 deletions components/PrintableMap.vue
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,12 @@ export default {
self.mapConfig.layer_settings,
source.updated_search_key
);
// eslint-disable-next-line array-callback-return
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 単にforEachに置き換えてもよさそうですが、なんらかの意図があるかもしれないので無効化しています。

markers.map((marker) => {
categories[marker.category] = true;
});
source.updated_at = updated_at;
// eslint-disable-next-line array-callback-return
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 単にforEachに置き換えてもよさそうですが、なんらかの意図があるかもしれないので無効化しています。

Object.keys(categories).map((category) => {
const categoryExists = self.mapConfig.layer_settings[category];

Expand Down Expand Up @@ -329,6 +331,7 @@ export default {
},
getMarkerNameText(markerProperties, locale) {
let name = markerProperties.name;
// eslint-disable-next-line no-prototype-builtins
if (markerProperties.hasOwnProperty("name:" + locale)) {
name = markerProperties["name:" + locale];
}
Expand Down
1 change: 1 addition & 0 deletions createtiles.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const _make_tilejson = (dir, base_name) => {

// load config
const list = require(`${CONFIG_DIR}list.json`)
// eslint-disable-next-line array-callback-return
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 単にforEachに置き換えてもよさそうですが、なんらかの意図があるかもしれないので無効化しています。

list.map((name) => {
// load map config
console.log(`loading ${CONFIG_DIR}${name}`)
Expand Down
1 change: 1 addition & 0 deletions nuxt.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ try {
if (fs.existsSync("./nuxt-router-override.config.js")) {
router = require("./nuxt-router-override.config").default;
}
// eslint-disable-next-line no-empty
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 単にfinallyブロックを削除してもよさそうですが、なんらかの意図があるかもしれないので無効化しています。

} finally {
}

Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"@babel/preset-typescript": "^7.23.3",
"@nuxt/test-utils": "^3.9.0",
"@nuxt/typescript-build": "^0.2.10",
"@nuxtjs/eslint-config": "^1.0.1",
"@nuxtjs/eslint-module": "^1.2.0",
"@nuxtjs/eslint-config": "^8.0.0",
"@nuxtjs/eslint-module": "^4.1.0",
"@playwright/test": "^1.40.1",
"@types/geojson": "^7946.0.7",
"@types/jest": "^29.5.11",
Expand All @@ -70,11 +70,11 @@
"babel-preset-vue": "^2.0.2",
"cross-env": "^6.0.3",
"css-mqpacker": "^7.0.0",
"eslint": "^6.8.0",
"eslint": "^7.32.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-html": "^6.1.1",
"eslint-plugin-nuxt": "^2.0.0",
"eslint-plugin-vue": "^7.7.0",
"eslint-plugin-html": "^7.1.0",
"eslint-plugin-nuxt": "^4.0.0",
"eslint-plugin-vue": "^9.19.2",
"fs": "0.0.1-security",
"jest": "^29.7.0",
"jest-dom": "^4.0.0",
Expand Down
1 change: 1 addition & 0 deletions plugins/simplebar.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* eslint-disable import/no-extraneous-dependencies */
import Vue from 'vue'
import simplebar from 'simplebar-vue'
// eslint-disable-next-line vue/multi-word-component-names
Vue.component('Simplebar', simplebar)
Loading
Loading