Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set target cluster for social events #454

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

alexeykazakov
Copy link
Contributor

@alexeykazakov alexeykazakov commented Aug 15, 2024

Set the target cluster for UserSignups if it's associated with a social event with the target cluster field set.

Part of https://issues.redhat.com/browse/SANDBOX-724

Paired with codeready-toolchain/toolchain-e2e#1035

Copy link

sonarcloud bot commented Aug 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.8% Duplication on New Code (required ≤ 20%)

See analysis details on SonarCloud

@alexeykazakov
Copy link
Contributor Author

/retest

Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

Copy link

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.62%. Comparing base (b123fb6) to head (affa450).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   78.59%   78.62%   +0.03%     
==========================================
  Files          42       42              
  Lines        2700     2704       +4     
==========================================
+ Hits         2122     2126       +4     
  Misses        487      487              
  Partials       91       91              
Flag Coverage Δ
unittests 78.62% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexeykazakov alexeykazakov merged commit 28556e0 into codeready-toolchain:master Aug 16, 2024
10 of 12 checks passed
@alexeykazakov alexeykazakov deleted the event-target branch August 16, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants