Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set target cluster for social events #1035

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Set target cluster for social events #1035

merged 3 commits into from
Aug 16, 2024

Conversation

alexeykazakov
Copy link
Contributor

@alexeykazakov alexeykazakov commented Aug 16, 2024 •
edited
Loading

@alexeykazakov alexeykazakov mentioned this pull request Aug 16, 2024
Merged
mfrancisc
mfrancisc reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I have only few minor comments.

test/e2e/parallel/registration_service_test.go Outdated Show resolved Hide resolved
test/e2e/parallel/registration_service_test.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
15.4% Duplication on New Code

See analysis details on SonarCloud

rajivnathan
rajivnathan approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov
Copy link
Contributor Author

Thank you for the review @mfrancisc @rajivnathan !

@alexeykazakov alexeykazakov merged commit ed01015 into codeready-toolchain:master Aug 16, 2024
8 of 9 checks passed
@alexeykazakov alexeykazakov deleted the event-target branch August 16, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrancisc mfrancisc mfrancisc left review comments

@rajivnathan rajivnathan rajivnathan approved these changes

@MatousJobanek MatousJobanek Awaiting requested review from MatousJobanek MatousJobanek is a code owner

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@sbryzak sbryzak Awaiting requested review from sbryzak

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeykazakov @mfrancisc @rajivnathan