Multinode trouble patch (field mode) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved the strings to replacer_blabla.lua
Use new Technic Plus tool API
respect param2 when replacing in field mode not doing so in crust mode as that would break usefulness also check for vacuum when placing in crust mode
…DogSearchImprovements
and some combined with double to single quotation marks
also makes infrastructure for post on_place actions besides adding support for direct placing of certain nodes that have special nodes depending on rotation.
This allows servers to restrict usage under dynamic conditions
Reduce Technic registration warnings
The drop list from engine is in reverse order, so e.g. when trying to set to leaves without leaves in main inventory, replacer would be set to sapling. This commit checks all drops first and if finds same drop as node, it is used. Otherwise the first in list is used.
Thanks Niklp09 for reporting. fixes: #47
when clicking on the 'wrong' part of a multinode-node, direction calculation is nerfed. This patch avoids a server crash and emits a sound and message. User can simply click on another part of the multinode- node and the procedure should work. I didn't bother adjusting the pointed_thing to make this work, as I don't consider the trouble worthwhile for this kind of node that breaks the voxel world. The bug was detected by player frogTheSecond and reported by Huhhila on pandorabox. Thanks guys.
typo fix by fluxionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when clicking on the 'wrong' part of a multinode-node,
direction calculation is nerfed. This patch avoids a
server crash and emits a sound and message.
User can simply click on another part of the multinode-
node and the procedure should work.
I didn't bother adjusting the pointed_thing to make this work, as I
don't consider the trouble worthwhile for this
kind of node that breaks the voxel world.
The bug was detected by player frogTheSecond and reported
by Huhhila on pandorabox. Thanks guys.