Multinode trouble patch (field mode)

.github/workflows/luacheck.yml

@@ -0,0 +1,14 @@
+name: luacheck
+on: [push, pull_request]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - name: apt
+      run: sudo apt-get install -y luarocks
+    - name: luacheck install
+      run: luarocks install --local luacheck
+    - name: luacheck run
+      run: $HOME/.luarocks/bin/luacheck ./
+

.luacheckrc

@@ -0,0 +1,30 @@
+
+globals = {
+	"replacer",
+	minetest = { fields = { "translate", "get_translator" } },
+}
+
+read_globals = {
+	-- Stdlib
+	string = { fields = { "split", "match", "find", "lower" } },
+	table = { fields = { "copy", "getn", "insert", "shuffle", "sort" } },
+
+	-- Minetest
+	"minetest",
+	"vector", "ItemStack",
+	"dump", "VoxelArea",
+
+	-- deps
+	"circular_saw",
+	"colormachine",
+	"creative",
+	"default",
+	"dye",
+	"flowers",
+	"moreblocks",
+	"stairsplus",
+	"technic",
+	"unified_inventory",
+	"unifieddyes",
+}
+

CHANGELOG

@@ -0,0 +1,115 @@
+20240225 * SwissalpS patched a crash situation with multinode-nodes. Thanks frogTheSecond and Huhhila for detecting and reporting.
+20221107 * fluxionary fixed typo unkown -> unknown
+20220830 * SwissalpS fixed de translation typo. Thanks Niklp09 for reporting.
+20220626 * SwissalpS fixed case where other drops were prefered from actual node that user tried to set to.
+20220624 * SX added technic.plus compat fix
+20220215 * SwissalpS added compat for itemholder and powered_stand when override is used
+           to make them work nicely:
+           https://github.com/pandorabox-io/pandorabox_custom/blob/master/scifi_override.lua
+20220214 * SwissalpS added compat for itemframe, pedestal, itemholder and powered_stand
+           (itemframes and scifi_nodes) showing info on what they are holding.
+20220210 * SwissalpS added some more info to inspection tool when inspecting players.
+20220205 * SwissalpS tweaked formspec of replacer to adjust when minor modes are disabled.
+         * Enabled changing modes with place without pointing at a node.
+         * Added more info on mobs.
+20220204 * SwissalpS added tooltip to protection info as that often clipped.
+         * fixed the alias resolving to not change node_name.
+         * fixed group:food_pumpkin.
+         * dropped datastructure usage for final sorting as it left weird patterns
+           when time-outs were reached. Instead using clasic table.sort with vector.distance
+           comparisons. Also using faster repeat ... until loop.
+         * In field and crust mode only count nodes that were actually changed.
+20220203 * SwissalpS fixed some issues: forced aliases, items that have no drops defined
+           Added compat for buckets, canisters and beertap/mugs
+           Fixed formspec for MT 5.5.0 (that now actually uses padding)
+           Added server setting to disable minor modes.
+           Updated documentation and locales.
+20220127 * SwissalpS cleaned up var names in inspect.lua
+         * Added .luacheckrc and print_dump()
+         * Bumped version to 4.0
+20220126 * SwissalpS improved some compat items and redid translations.
+         * Documentation updated.
+         * Added LICENSE file.
+20220125 * SwissalpS improved sytem for showing dynamicly added crafting methods
+           which allowed to improve the output of technic and saw methods.
+         * Better drop detection method.
+         * Added sound playback for setting replacer errors, mainly.
+         * Change /replacer_mute to /replacer and changed the arguments
+           so sound can be muted separately.
+         * Added tooltips so users have more chance of reading long lines. Adding
+           textarea to make itemstring selectable failed and is post-poned to when
+           new version of formspec is being used for inspection tool as well.
+         * Added experimental hold zoom+click with inspection tool to open unified_inventory.
+20220124 * SwissalpS added wrap around for recipes - yes, long due.
+         * Bugfix, now replacer actually checks groups.
+         * Compat for shears (wool & vines) also fermenting/pickling, advtrains and sci-fi plastic
+         * ehlphabet and letters compat.
+20220123 * SwissalpS added dev-mode and /place_all chat command.
+         * Technic crafting methods for inspection tool, including cnc nodes.
+         * planetoidgen:airlight is treated as air.
+         * New way to determine if replacer can be set to node
+           implementing callbacks better. Such as group denial.
+         * A lot of compatibility added to many mods.
+20220120 * SwissalpS made folder structure to create easier overview.
+         * Improved circular saw item detection for inspect and replacer.
+         * Added beacon beam and base support (no longer needed to be in inv when setting).
+         * Inspection tool now inspects light correctly and respects right-click.
+         * Added locale for inspection tool.
+20220119 * SwissalpS added first draft of de,es,fi,fr,it,pt,ru locales.
+20220118 * SwissalpS cleaned up more code, giving more discriptive variable names and
+           cleaning out ugly modes table that had both number and string indexes
+         * Don't allow replacer to be set to deny_list nodes
+         * History works for users with priv. Various settings added to
+           fine-tune how it behaves.
+         * Implemented minor-modes with more colours ;)
+         * Added non-formspec way to cycle minor modes: Special+Sneak+right-click
+         * Especially in functions with tight loops, local references to global functions was added.
+20220117 * SwissalpS changed mode storage in tool meta to major.minor format
+         * Added version 4 formspec that enables changing minor mode
+           and has prepared history selector.
+         * Moved changelog and cleaned it up adding some dates
+         * Moved formspec code to separate file.
+         * Started implementing translations and history.
+20220115 * SwissalpS refactored constraints and renamed blacklist to deny_list
+20220114 * SwissalpS added support for cable plates and similar nodes
+20220113 * SwissalpS worked in HybridDog's nicer pattern algorithm, modifying a little.
+           Also cleaned up some code and give-priv does not grant modes anymore,
+           creative still does.
+20220112 * SwissalpS improved field mode: when replacing also check for same param2
+           improved crust mode: when placing also allow vacuum instead of only air
+20211202 * SwissalpS added /replacer_mute command
+20210930 * SwissalpS merged patch provided by S-S-X to prevent a rare but possible crash with
+           Unknown Items in hotbar
+         * Also cleaned up tool change messages to blabla.lua
+20201016 * HybridDog provided first documentation and SwissalpS added some more explaining modes.
+20201015 * SwissalpS cleaned up inspector code and made inspector better readable on smaller screens
+20200322 * HybridDog removed fourth mode and improved node search
+         * SwissalpS added backward compatibility for non technic servers, restored
+           creative/give behaviour and fixed the 'too many nodes detected' issue
+         * S-S-X and some players from pandorabox.io requested and inspired ideas to
+           implement which SwissalpS tried to satisfy.
+20200131 * SwissalpS added method to change mode via formspec
+20200109 * BuckarooBanzay added server-setting max_nodes, moved crafts and replacer to
+           separate files, added .luacheckrc and cleaned up inspection tool, fixing
+           some issues on the way and updated readme to look nice
+20191217 * OgelGames fixed digging to be simulated properly
+20191212 * coil0 made modes available as technic tool and added limits
+         * SwissalpS merged Sokomine's and HybridDog's versions
+         * HybridDog added modes for creative mode
+20190628 * coil0 fixed issue by using buildable_to
+20171209 * Got rid of outdated minetest.env
+         * Fixed error in protection function.
+         * Fixed minor bugs.
+         * Added blacklist
+20141002 * Some more improvements for inspect-tool. Added craft-guide.
+20141001 * Added inspect-tool.
+20130112 * If digging the node was unsuccessful, then the replacement will now fail
+           (instead of destroying the old node with its metadata; i.e. chests with content)
+20131120 * if the server version is new enough, minetest.is_protected is used
+           in order to check if the replacement is allowed
+20130424 * param1 and param2 are now stored
+         * hold sneak + right click to store new pattern
+         * right click: place one of the itmes
+         * receipe changed
+         * inventory image added
+

LICENSE

@@ -0,0 +1,166 @@
+                   GNU LESSER GENERAL PUBLIC LICENSE
+                       Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+
+  This version of the GNU Lesser General Public License incorporates
+the terms and conditions of version 3 of the GNU General Public
+License, supplemented by the additional permissions listed below.
+
+  0. Additional Definitions.
+
+  As used herein, "this License" refers to version 3 of the GNU Lesser
+General Public License, and the "GNU GPL" refers to version 3 of the GNU
+General Public License.
+
+  "The Library" refers to a covered work governed by this License,
+other than an Application or a Combined Work as defined below.
+
+  An "Application" is any work that makes use of an interface provided
+by the Library, but which is not otherwise based on the Library.
+Defining a subclass of a class defined by the Library is deemed a mode
+of using an interface provided by the Library.
+
+  A "Combined Work" is a work produced by combining or linking an
+Application with the Library.  The particular version of the Library
+with which the Combined Work was made is also called the "Linked
+Version".
+
+  The "Minimal Corresponding Source" for a Combined Work means the
+Corresponding Source for the Combined Work, excluding any source code
+for portions of the Combined Work that, considered in isolation, are
+based on the Application, and not on the Linked Version.
+
+  The "Corresponding Application Code" for a Combined Work means the
+object code and/or source code for the Application, including any data
+and utility programs needed for reproducing the Combined Work from the
+Application, but excluding the System Libraries of the Combined Work.
+
+  1. Exception to Section 3 of the GNU GPL.
+
+  You may convey a covered work under sections 3 and 4 of this License
+without being bound by section 3 of the GNU GPL.
+
+  2. Conveying Modified Versions.
+
+  If you modify a copy of the Library, and, in your modifications, a
+facility refers to a function or data to be supplied by an Application
+that uses the facility (other than as an argument passed when the
+facility is invoked), then you may convey a copy of the modified
+version:
+
+   a) under this License, provided that you make a good faith effort to
+   ensure that, in the event an Application does not supply the
+   function or data, the facility still operates, and performs
+   whatever part of its purpose remains meaningful, or
+
+   b) under the GNU GPL, with none of the additional permissions of
+   this License applicable to that copy.
+
+  3. Object Code Incorporating Material from Library Header Files.
+
+  The object code form of an Application may incorporate material from
+a header file that is part of the Library.  You may convey such object
+code under terms of your choice, provided that, if the incorporated
+material is not limited to numerical parameters, data structure
+layouts and accessors, or small macros, inline functions and templates
+(ten or fewer lines in length), you do both of the following:
+
+   a) Give prominent notice with each copy of the object code that the
+   Library is used in it and that the Library and its use are
+   covered by this License.
+
+   b) Accompany the object code with a copy of the GNU GPL and this license
+   document.
+
+  4. Combined Works.
+
+  You may convey a Combined Work under terms of your choice that,
+taken together, effectively do not restrict modification of the
+portions of the Library contained in the Combined Work and reverse
+engineering for debugging such modifications, if you also do each of
+the following:
+
+   a) Give prominent notice with each copy of the Combined Work that
+   the Library is used in it and that the Library and its use are
+   covered by this License.
+
+   b) Accompany the Combined Work with a copy of the GNU GPL and this license
+   document.
+
+   c) For a Combined Work that displays copyright notices during
+   execution, include the copyright notice for the Library among
+   these notices, as well as a reference directing the user to the
+   copies of the GNU GPL and this license document.
+
+   d) Do one of the following:
+
+       0) Convey the Minimal Corresponding Source under the terms of this
+       License, and the Corresponding Application Code in a form
+       suitable for, and under terms that permit, the user to
+       recombine or relink the Application with a modified version of
+       the Linked Version to produce a modified Combined Work, in the
+       manner specified by section 6 of the GNU GPL for conveying
+       Corresponding Source.
+
+       1) Use a suitable shared library mechanism for linking with the
+       Library.  A suitable mechanism is one that (a) uses at run time
+       a copy of the Library already present on the user's computer
+       system, and (b) will operate properly with a modified version
+       of the Library that is interface-compatible with the Linked
+       Version.
+
+   e) Provide Installation Information, but only if you would otherwise
+   be required to provide such information under section 6 of the
+   GNU GPL, and only to the extent that such information is
+   necessary to install and execute a modified version of the
+   Combined Work produced by recombining or relinking the
+   Application with a modified version of the Linked Version. (If
+   you use option 4d0, the Installation Information must accompany
+   the Minimal Corresponding Source and Corresponding Application
+   Code. If you use option 4d1, you must provide the Installation
+   Information in the manner specified by section 6 of the GNU GPL
+   for conveying Corresponding Source.)
+
+  5. Combined Libraries.
+
+  You may place library facilities that are a work based on the
+Library side by side in a single library together with other library
+facilities that are not Applications and are not covered by this
+License, and convey such a combined library under terms of your
+choice, if you do both of the following:
+
+   a) Accompany the combined library with a copy of the same work based
+   on the Library, uncombined with any other library facilities,
+   conveyed under the terms of this License.
+
+   b) Give prominent notice with the combined library that part of it
+   is a work based on the Library, and explaining where to find the
+   accompanying uncombined form of the same work.
+
+  6. Revised Versions of the GNU Lesser General Public License.
+
+  The Free Software Foundation may publish revised and/or new versions
+of the GNU Lesser General Public License from time to time. Such new
+versions will be similar in spirit to the present version, but may
+differ in detail to address new problems or concerns.
+
+  Each version is given a distinguishing version number. If the
+Library as you received it specifies that a certain numbered version
+of the GNU Lesser General Public License "or any later version"
+applies to it, you have the option of following the terms and
+conditions either of that published version or of any later version
+published by the Free Software Foundation. If the Library as you
+received it does not specify a version number of the GNU Lesser
+General Public License, you may choose any version of the GNU Lesser
+General Public License ever published by the Free Software Foundation.
+
+  If the Library as you received it specifies that a proxy can decide
+whether future versions of the GNU Lesser General Public License shall
+apply, that proxy's public statement of acceptance of any version is
+permanent authorization for you to choose that version for the
+Library.
+