Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide browser-ready bundle (requires zod import-map) #46

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Sep 24, 2024

No description provided.

@brettz9
Copy link
Contributor Author

brettz9 commented Sep 26, 2024

The --legacy-output option seems to be the one way it won't overwrite our existing dist/index.js file (overwriting it may be ok as far as Node, but wouldn't think so for TypeScript which writes to different files).

@Gregoor Gregoor merged commit 995ed37 into commonbaseapp:main Sep 27, 2024
5 checks passed
@Gregoor
Copy link
Collaborator

Gregoor commented Sep 27, 2024

Let's give it a shot!

@brettz9 brettz9 deleted the tsup branch September 27, 2024 13:13
@brettz9
Copy link
Contributor Author

brettz9 commented Sep 27, 2024

Looks like there was a publish error: https://github.com/commonbaseapp/zodex/actions/runs/11071258234/job/30762829124

@brettz9 brettz9 mentioned this pull request Sep 27, 2024
@brettz9
Copy link
Contributor Author

brettz9 commented Oct 8, 2024

The error is indicating you've already published "0.0.0-dev". Is this some kind of bug with semantic-release?

@Gregoor
Copy link
Collaborator

Gregoor commented Oct 9, 2024

Hm yeah maybe, it was working before, it's not clear to me from the log what might have broken

@brettz9
Copy link
Contributor Author

brettz9 commented Oct 10, 2024

Shall I file an issue with https://github.com/go-semantic-release/action ?

@Gregoor
Copy link
Collaborator

Gregoor commented Oct 11, 2024

I think we should be able to figure this out, it ran just fine before merging this PR:

So I guess we just need to figure out: what changed OR what isn't deterministic about our CI

@brettz9
Copy link
Contributor Author

brettz9 commented Oct 11, 2024

The changes though would need to look back, I think, to the last version (the previous PRs didn't fail as they didn't necessitate a version change), and there have been a number of changes, including the workspace changes, since that version was published: v0.18.2...v0.19.0 .

@Gregoor
Copy link
Collaborator

Gregoor commented Oct 11, 2024

true, you're right, I looked at the wrong thing!

@brettz9
Copy link
Contributor Author

brettz9 commented Oct 12, 2024

Don't know how well this applies, but per go-semantic-release/semantic-release#77 , there is no support for monorepos in go-semantic-release.

This comes up as a top Google search result: https://github.com/pmowrer/semantic-release-monorepo and has instructions for pnpm.

@Gregoor
Copy link
Collaborator

Gregoor commented Oct 12, 2024

Uuh yeah dang, that makes a lot of sense, I didn't think about those implications, thank you for doing that for me. I'll do some thinking from here how to resolve it!

@brettz9
Copy link
Contributor Author

brettz9 commented Dec 9, 2024

Hiya... Wondering if you might have some time to revisit this?

@Gregoor
Copy link
Collaborator

Gregoor commented Dec 11, 2024

I fear I won't be finding the time for it in the next while, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants