-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flash-attn v2.6.3 + TORCH_CUDA_ARCH_LIST=8.0;8.6;8.9;9.0+PTX #10
flash-attn v2.6.3 + TORCH_CUDA_ARCH_LIST=8.0;8.6;8.9;9.0+PTX #10
Conversation
…nda-forge-pinning 2024.07.23.22.35.38
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Looks like we are exceeding the 6 hour limit even when building for only a single arch. Looks like we need to finish the process to get on the Quantsight GPU server. @weiji14, could you please agree to the terms of use for the Quantsight GPU severs by opening a pull request here: https://github.com/Quansight/open-gpu-server Then we can open a request to have the bot enable the Quantsight GPU server for this feedstock using this template: https://github.com/conda-forge/admin-requests/blob/main/examples/example-open-gpu-server.yml |
Sure, let me work on that later, recent builds have been too close to the 6hr mark and I've had to restart CI for the past two releases already, and would be good to handle more CUDA archs (xref #4). Not sure if we actually need a GPU-enabled server though, maybe just a longer timeout (+more CPU/RAM)? |
The only way to accomplish builds longer than 6 hours is to use Quantsight's servers. I'm not sure what options Quantsight provides for servers with/without GPUs, but this package is a CUDA enabled package, so we should just use the GPU server list. |
…nda-forge-pinning 2024.07.25.23.42.20
…nda-forge-pinning 2024.07.26.18.03.15
TODO:
|
On the openstack runners, the jobs are crashing during the first compilation phase. Trying to reduce the number of concurrent compilations to 2 in order to prevent this crash (from a max of 4). |
Maybe they're not crashing? Maybe the jobs are just being killed at 30mins? |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.07.30.01.49.09
Try to fix `torch 2.4.1.post300 requires setuptools, which is not installed`.
…nda-forge-pinning 2024.10.12.13.15.35
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks @jakirkham for the merge tips 🙏 The previous test build with CUDA 11.8 / Python 3.12 seems to have completed successfully on I'm now testing CUDA 12.0 / Python 3.13 (cherry-picking from #17) at commit e4e877b, and if this builds complete within the time limit, I think we should have enough info on what resources will be needed for the full matrix builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, are we ready for the full matrix builds?
|
Co-authored-by: Wei Ji <[email protected]>
@conda-forge-admin, please rerender |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait. Setuptools is not a runtime dependency of this package. Pytorch needs to fix its missing/extra dependency, not us.
…nda-forge-pinning 2024.10.15.15.47.23
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.15.15.47.23
Co-authored-by: Wei Ji <[email protected]>
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.15.15.47.23
Thanks Daniel! 🙏 Looks like cirun doesn't like the bot commit. So may need to push another commit |
Unsure why rerender at 3051209 reverted to 2160 mins.
…nda-forge-pinning 2024.10.15.17.49.24
Ok, re-rendered manually using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds all pass now 🎉 Longest one was CUDA 11.8 / Python 3.12 that took 8h 26m 41s (under the 9h time limit).
Shall we wait for conda-forge/pytorch-cpu-feedstock#276, and then we can include the Python 3.13 builds here too?
skip: true # [cuda_compiler_version in (undefined, "None")] | ||
skip: true # [not linux] | ||
skip: true # [py==313] # Skip until pytorch dependency on setuptools is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove after conda-forge/pytorch-cpu-feedstock#276 is merged (remember to re-render manually afterwards).
skip: true # [py==313] # Skip until pytorch dependency on setuptools is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to rebuild to add those additional modules requested in #18. We can see if pytorch is ready for 3.13 then.
Hooray! 🥳 Excellent work 😄 Thank you both! 🙏 |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.
Closes #11
Closes #17