-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding acryl-datahub #28897
base: main
Are you sure you want to change the base?
adding acryl-datahub #28897
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
836f627
to
f878849
Compare
Commenting that I am ok being listed as maintainer |
125440d
to
780511a
Compare
Commenting that I am ok being listed as maintainer |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/acryl-datahub/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12930350019. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/acryl-datahub/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12932584167. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review! |
Commenting that I am ok being listed as maintainer |
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/acryl_datahub-{{ version }}.tar.gz | ||
sha256: 6b1b8591bb485b2aa51010052758e9a7b2dee2030c8b373b72e944c570935f28 | ||
|
||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like this package should probably be noarch: python
. See:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
Take note of changes related to python_min
. I think the main thing you were struggling with is that even though upstream says it supports python>=3.8
, in reality that metadata is wrong since they are using typing syntax that would require you to set python_min = 3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are tests running that check that it works on Python 3.8 https://github.com/datahub-project/datahub/actions/runs/12946781664
In the conda pipelines it was running it on Python 3.12
recipes/acryl-datahub/meta.yaml
Outdated
build: | ||
entry_points: | ||
- datahub = datahub.entrypoints:main | ||
skip: True # [win or osx or py>=312 or py<38] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me why this won't run on osx given the metadata in the upstream setup.py
. In general though, I think this can be noarch: python
and this skip
section can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed win, osx and just keeping python skips
caa1f14
to
2c00154
Compare
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).