Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding acryl-datahub #28897

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

anshbansal
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/acryl-datahub/meta.yaml) and found it was in an excellent condition.

@anshbansal anshbansal closed this Jan 22, 2025
@anshbansal anshbansal reopened this Jan 22, 2025
@anshbansal anshbansal force-pushed the ab-2025-jan-22-acryl-datahub branch from 836f627 to f878849 Compare January 22, 2025 13:15
@anshbansal
Copy link
Contributor Author

Commenting that I am ok being listed as maintainer

@anshbansal anshbansal force-pushed the ab-2025-jan-22-acryl-datahub branch from 125440d to 780511a Compare January 23, 2025 11:07
@pedro93
Copy link

pedro93 commented Jan 23, 2025

Commenting that I am ok being listed as maintainer

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/acryl-datahub/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/acryl-datahub/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12930350019. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/acryl-datahub/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 23, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/acryl-datahub/meta.yaml) and found some lint.

Here's what I've got...

For recipes/acryl-datahub/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12932584167. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/acryl-datahub/meta.yaml) and found it was in an excellent condition.

@anshbansal
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

@hsheth2
Copy link

hsheth2 commented Jan 23, 2025

Commenting that I am ok being listed as maintainer

url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/acryl_datahub-{{ version }}.tar.gz
sha256: 6b1b8591bb485b2aa51010052758e9a7b2dee2030c8b373b72e944c570935f28

build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like this package should probably be noarch: python. See:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python

Take note of changes related to python_min. I think the main thing you were struggling with is that even though upstream says it supports python>=3.8, in reality that metadata is wrong since they are using typing syntax that would require you to set python_min = 3.10

Copy link
Contributor Author

@anshbansal anshbansal Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests running that check that it works on Python 3.8 https://github.com/datahub-project/datahub/actions/runs/12946781664

In the conda pipelines it was running it on Python 3.12

build:
entry_points:
- datahub = datahub.entrypoints:main
skip: True # [win or osx or py>=312 or py<38]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why this won't run on osx given the metadata in the upstream setup.py. In general though, I think this can be noarch: python and this skip section can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed win, osx and just keeping python skips

@anshbansal anshbansal force-pushed the ab-2025-jan-22-acryl-datahub branch from caa1f14 to 2c00154 Compare January 24, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants