-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding acryl-datahub #28897
Open
anshbansal
wants to merge
19
commits into
conda-forge:main
Choose a base branch
from
acryldata:ab-2025-jan-22-acryl-datahub
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
adding acryl-datahub #28897
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
64e89cf
adding acryl-datahub
anshbansal 010584c
end of file line
anshbansal 94c7daa
Update meta.yaml
anshbansal b1adc35
fix home
anshbansal 4489c2b
use relative path to get LICENSE from parent directory
anshbansal a1b35e6
add license manually here
anshbansal 070588e
remove LICENSE, update version
anshbansal f9bf305
update version
anshbansal d8346b5
Add pedro as maintainer
anshbansal f670460
updated sha
anshbansal e596e96
change version
anshbansal db42d2e
Add back syntax
anshbansal 2e006ad
remove datahub provider import
anshbansal 41fb2f8
set max as python 3.11
anshbansal 307bb7e
add skip
anshbansal df38551
remove noarch
anshbansal 2ab474d
try to remove version constraint
anshbansal df5946c
remove arch
anshbansal 2c00154
add harshal
anshbansal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| {% set name = "acryl-datahub" %} | ||
| {% set version = "0.15.0.4" %} | ||
|
|
||
| package: | ||
| name: {{ name|lower }} | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/acryl_datahub-{{ version }}.tar.gz | ||
| sha256: 6b1b8591bb485b2aa51010052758e9a7b2dee2030c8b373b72e944c570935f28 | ||
|
|
||
| build: | ||
| entry_points: | ||
| - datahub = datahub.entrypoints:main | ||
| skip: True # [py>=312 or py<38] | ||
| script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation | ||
| number: 0 | ||
|
|
||
| requirements: | ||
| host: | ||
| - python | ||
| - setuptools >=63.0.0 | ||
| - wheel | ||
| - pip | ||
| run: | ||
| - python | ||
| - requests-file | ||
| - avro-gen3 ==0.7.16 | ||
| - tabulate | ||
| - click-spinner | ||
| - importlib-metadata >=4.0.0 | ||
| - cached_property | ||
| - toml >=0.10.0 | ||
| - typing_extensions >=4.2.0 | ||
| - click >=7.1.2 | ||
| - packaging | ||
| - pyyaml | ||
| - jsonref | ||
| - python-dateutil >=2.8.0 | ||
| - ijson | ||
| - humanfriendly | ||
| - deprecated | ||
| - sentry-sdk | ||
| - expandvars >=0.6.5 | ||
| - avro >=1.11.3,<1.12 | ||
| - typing_inspect | ||
| - psutil >=5.8.0 | ||
| - pydantic >=1.10.0,!=1.10.3 | ||
| - click-default-group | ||
| - docker-py | ||
| - mixpanel >=4.9.0 | ||
| - aiohttp <4 | ||
| - jsonschema | ||
| - ruamel.yaml | ||
| - progressbar2 | ||
|
|
||
| test: | ||
| imports: | ||
| - datahub | ||
| commands: | ||
| - pip check | ||
| - datahub --help | ||
| requires: | ||
| - python | ||
| - pip | ||
|
|
||
| about: | ||
| home: https://github.com/datahub-project/datahub | ||
| summary: A CLI to work with DataHub metadata | ||
| license: Apache-2.0 | ||
| license_file: LICENSE | ||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - anshbansal | ||
| - pedro93 | ||
| - hsheth2 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like this package should probably be
noarch: python. See:https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
Take note of changes related to
python_min. I think the main thing you were struggling with is that even though upstream says it supportspython>=3.8, in reality that metadata is wrong since they are using typing syntax that would require you to setpython_min = 3.10There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are tests running that check that it works on Python 3.8 https://github.com/datahub-project/datahub/actions/runs/12946781664
In the conda pipelines it was running it on Python 3.12